shadowinlife commented on a change in pull request #28618:
URL: https://github.com/apache/spark/pull/28618#discussion_r430234848
##########
File path:
core/src/main/java/org/apache/spark/shuffle/api/ShuffleMapOutputWriter.java
##########
@@ -63,7 +64,7 @@
* The returned array should contain, for each partition from (0) to
(numPartitions - 1), the
* number of bytes written by the partition writer for that partition id.
*/
Review comment:
Suggest change the comments of this code
##########
File path:
core/src/main/java/org/apache/spark/shuffle/api/ShuffleMapOutputWriter.java
##########
@@ -63,7 +64,7 @@
* The returned array should contain, for each partition from (0) to
(numPartitions - 1), the
* number of bytes written by the partition writer for that partition id.
*/
- long[] commitAllPartitions() throws IOException;
+ MapOutputCommitMessage commitAllPartitions() throws IOException;
Review comment:
Suggest change the relate comments of this code, the return is an object
instead of array
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
