[GitHub] [spark] srowen commented on issue #26427: [SPARK-29795][CORE] Explicitly clear registered metrics on MetricSystem shutdown

2019-11-09 Thread GitBox
srowen commented on issue #26427: [SPARK-29795][CORE] Explicitly clear 
registered metrics on MetricSystem shutdown
URL: https://github.com/apache/spark/pull/26427#issuecomment-552107047
 
 
   Merged to master


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] srowen commented on issue #26427: [SPARK-29795][CORE] Explicitly clear registered metrics on MetricSystem shutdown

2019-11-07 Thread GitBox
srowen commented on issue #26427: [SPARK-29795][CORE] Explicitly clear 
registered metrics on MetricSystem shutdown
URL: https://github.com/apache/spark/pull/26427#issuecomment-551242710
 
 
   Let's hold off a bit merging this, just as I want to collect as much 
feedback as possible that we're not missing something.
   
   BTW I do not think this has to be back-ported to 2.4


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org