[GitHub] [spark] srowen commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
srowen commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637627749 Oops right I meant Locale, not TZ. OK makes sense. This is an automated message from the Apache Git Service.

[GitHub] [spark] srowen commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-02 Thread GitBox
srowen commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637538510 Just for my info, why was Monday the first day of week in 2.4 then? we didn't use TZ to determine it? Also is that the right answer from a SQL standard or Hive perspective?

[GitHub] [spark] srowen commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-01 Thread GitBox
srowen commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-636992427 Wow, really? Monday is considered the first day of week in the US locale? I'm a little uneasy about defaulting to GB, as it might have other implications. What does the