[GitHub] [spark] srowen commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters
srowen commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637627749 Oops right I meant Locale, not TZ. OK makes sense. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters
srowen commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-637538510 Just for my info, why was Monday the first day of week in 2.4 then? we didn't use TZ to determine it? Also is that the right answer from a SQL standard or Hive perspective? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters
srowen commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-636992427 Wow, really? Monday is considered the first day of week in the US locale? I'm a little uneasy about defaulting to GB, as it might have other implications. What does the root locale do here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
