[GitHub] [spark] vinodkc commented on pull request #38146: [SPARK-40687][SQL] Support data masking built-in function 'mask'

vinodkc commented on PR #38146: URL: https://github.com/apache/spark/pull/38146#issuecomment-1377734764 Thanks for the suggestions , I'll raise a new PR to change -1 to NULL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] vinodkc commented on pull request #38146: [SPARK-40687][SQL] Support data masking built-in function 'mask'

vinodkc commented on PR #38146: URL: https://github.com/apache/spark/pull/38146#issuecomment-1377706874 @srielau , Thanks for checking this. There is no specific reason other than following same approach as in Hive documentation:

[GitHub] [spark] vinodkc commented on pull request #38146: [SPARK-40687][SQL] Support data masking built-in function 'mask'

vinodkc commented on PR #38146: URL: https://github.com/apache/spark/pull/38146#issuecomment-1344455185 @gengliangwang, Review comments are addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] vinodkc commented on pull request #38146: [SPARK-40687][SQL] Support data masking built-in function 'mask'

vinodkc commented on PR #38146: URL: https://github.com/apache/spark/pull/38146#issuecomment-1337857038 @HyukjinKwon , @dtenedor , Can you please check this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] vinodkc commented on pull request #38146: [SPARK-40687][SQL] Support data masking built-in function 'mask'

vinodkc commented on PR #38146: URL: https://github.com/apache/spark/pull/38146#issuecomment-1306022238 Hi @dtenedor , @HyukjinKwon @gengliangwang Review comments are resolved, can you please check -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] vinodkc commented on pull request #38146: [SPARK-40687][SQL] Support data masking built-in function 'mask'

vinodkc commented on PR #38146: URL: https://github.com/apache/spark/pull/38146#issuecomment-1294245157 @dtenedor , yes, please close yours as a dup. I appreciate your help in reviewing this PR and on top of this change, I'm planning to add additional built-in mask functions supported

[GitHub] [spark] vinodkc commented on pull request #38146: [SPARK-40687][SQL] Support data masking built-in function 'mask'

vinodkc commented on PR #38146: URL: https://github.com/apache/spark/pull/38146#issuecomment-1291114363 > Reference snowflake: https://docs.snowflake.com/en/user-guide/security-column-ddm-use.html @melin Thanks to the reference from Snoflake, which describes dynamic data masking

[GitHub] [spark] vinodkc commented on pull request #38146: [SPARK-40687][SQL] Support data masking built-in Function 'mask'

vinodkc commented on PR #38146: URL: https://github.com/apache/spark/pull/38146#issuecomment-1272016984 @HyukjinKwon , this PR is a generic approach to mask the string based on the arguments. This mask function can be applied to any string value and it does not expect a pattern on the