[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-22 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429117869 ## File path: docs/sql-ref-datetime-pattern.md ## @@ -26,44 +26,128 @@ There are several common scenarios for datetime usage in Spark: - Datetime funct

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-22 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429110475 ## File path: sql/core/src/test/resources/sql-tests/results/datetime.sql.out ## @@ -750,3 +750,164 @@ select to_timestamp("2019 10:10:10", " hh:mm:ss

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-22 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429110475 ## File path: sql/core/src/test/resources/sql-tests/results/datetime.sql.out ## @@ -750,3 +750,164 @@ select to_timestamp("2019 10:10:10", " hh:mm:ss

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-22 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429093201 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -33,6 +34,8 @@ sealed trait DateFormatter extends

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-21 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428667113 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -40,7 +43,23 @@ class Iso8601DateFormatter( ex

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-21 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428667113 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -40,7 +43,23 @@ class Iso8601DateFormatter( ex

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-21 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428607225 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime-corrected.sql ## @@ -0,0 +1,2 @@ +--SET spark.sql.legacy.timeParserPolicy=CORRECTED

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-21 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428606030 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -40,7 +43,23 @@ class Iso8601DateFormatter( ex

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-21 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428604890 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -77,14 +96,14 @@ trait LegacyDateFormatter extend

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-20 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428000557 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -122,3 +122,13 @@ select to_timestamp("2019-10-06T10:11:12'12", "-MM-d

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-20 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428000557 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -122,3 +122,13 @@ select to_timestamp("2019-10-06T10:11:12'12", "-MM-d

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-20 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r427960736 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -122,3 +122,13 @@ select to_timestamp("2019-10-06T10:11:12'12", "-MM-d

[GitHub] [spark] yaooqinn commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-20 Thread GitBox
yaooqinn commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r427956371 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -122,3 +122,13 @@ select to_timestamp("2019-10-06T10:11:12'12", "-MM-d