[GitHub] [spark] zhengruifeng commented on issue #26415: [SPARK-18409][ML] LSH approxNearestNeighbors should use approxQuantile instead of sort

2019-11-09 Thread GitBox
zhengruifeng commented on issue #26415: [SPARK-18409][ML] LSH approxNearestNeighbors should use approxQuantile instead of sort URL: https://github.com/apache/spark/pull/26415#issuecomment-552077395 In some case (i.e. small datasets), we may want a exact result. so we may need to keep curre

[GitHub] [spark] zhengruifeng commented on issue #26415: [SPARK-18409][ML] LSH approxNearestNeighbors should use approxQuantile instead of sort

2019-11-09 Thread GitBox
zhengruifeng commented on issue #26415: [SPARK-18409][ML] LSH approxNearestNeighbors should use approxQuantile instead of sort URL: https://github.com/apache/spark/pull/26415#issuecomment-552077143 Maybe we can add a new param like `method`, it support serveral option: 1, exact, existing