gatorsmile commented on a change in pull request #23553: [SPARK-23710][SQL] Upgrade built-in Hive to 2.3.4 URL: https://github.com/apache/spark/pull/23553#discussion_r248007064
########## File path: sql/core/pom.xml ########## @@ -86,15 +86,17 @@ <scope>test</scope> </dependency> + <dependency> + <groupId>org.apache.hive</groupId> + <artifactId>hive-storage-api</artifactId> + </dependency> Review comment: Yes. We should not do this. sql/core dos not depend on hive at all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org