[GitHub] spark issue #15261: [SPARK-16356][Follow-up][ML] Enforce ML test of exceptio...
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15261 Merged into master, thanks for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15261: [SPARK-16356][Follow-up][ML] Enforce ML test of exceptio...
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15261 @srowen Would you mind to have a look when you are available? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15261: [SPARK-16356][Follow-up][ML] Enforce ML test of exceptio...
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15261 @HyukjinKwon The root cause of this is Spark supported creating local Dataset which may not trigger a Spark job. This satisfied the design of Dataset, and in most case the have the same behavior for local and distributed Dataset except whether to wrapper the exception. We need to enforce the test in ML. If Spark SQL guys unified them in the future, we can make corresponding change. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15261: [SPARK-16356][Follow-up][ML] Enforce ML test of exceptio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15261 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15261: [SPARK-16356][Follow-up][ML] Enforce ML test of exceptio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15261 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65964/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15261: [SPARK-16356][Follow-up][ML] Enforce ML test of exceptio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15261 **[Test build #65964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65964/consoleFull)** for PR 15261 at commit [`c24021e`](https://github.com/apache/spark/commit/c24021e4a24413426ae01fbbbc39d1a21e7aaf88). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15261: [SPARK-16356][Follow-up][ML] Enforce ML test of exceptio...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15261 So, this is roughly error from driver-side vs executor side. I see. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15261: [SPARK-16356][Follow-up][ML] Enforce ML test of exceptio...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15261 Oh, I see. Thanks for looking into this. +1 for this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15261: [SPARK-16356][Follow-up][ML] Enforce ML test of exceptio...
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15261 cc @HyukjinKwon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15261: [SPARK-16356][Follow-up][ML] Enforce ML test of exceptio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15261 **[Test build #65964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65964/consoleFull)** for PR 15261 at commit [`c24021e`](https://github.com/apache/spark/commit/c24021e4a24413426ae01fbbbc39d1a21e7aaf88). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
