Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15409
@srinathshankar brought up a good point. Since it is a small change and
doesnt' impact correctness, I'm going to merge this in master.
@srinathshankar when you add the Python API for crossjoin,
Github user bkpathak commented on the issue:
https://github.com/apache/spark/pull/15409
@rxin , @srinathshankar Could you please review the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15409
**[Test build #3303 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3303/consoleFull)**
for PR 15409 at commit
[`bf18321`](https://github.com/apache/spark/commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15409
**[Test build #3303 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3303/consoleFull)**
for PR 15409 at commit
[`bf18321`](https://github.com/apache/spark/commit/
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15409
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user bkpathak commented on the issue:
https://github.com/apache/spark/pull/15409
Hi @rxin, I removed those lines and fixed the errors. @srinathshankar
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15409
Oh well the test cases have issues. You can run those by `python/run-tests
--module pyspark-sql`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15409
**[Test build #3302 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3302/consoleFull)**
for PR 15409 at commit
[`cec8ec4`](https://github.com/apache/spark/commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15409
**[Test build #3302 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3302/consoleFull)**
for PR 15409 at commit
[`cec8ec4`](https://github.com/apache/spark/commit/
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15409
The change itself LGTM, but also cc @srinathshankar.
Right now Python behavior differs from Scala with respect to how crossJoin
is handled.
---
If your project is set up for it, you can reply
Github user bkpathak commented on the issue:
https://github.com/apache/spark/pull/15409
@holdenk @JoshRosen Can you please review this pull requst.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15409
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
12 matches
Mail list logo
