Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15471
merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15471
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/15471
Thanks @HyukjinKwon - The appveyor tests seem to pass as well
Change LGTM to merge to master. @felixcheung Any other comments ?
---
If your project is set up for it, you can reply to this
Github user falaki commented on the issue:
https://github.com/apache/spark/pull/15471
@shivaram that is fine. We can merge it to 2.1 (or whatever the next major
release is going to be).
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15471
Build started: [SparkR] `ALL`
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/15471
@falaki The code change looks pretty good to me, but I'm still a bit
worried about introducing a big change in a minor release. Can we have this
disabled by default and flip the flag only in the
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/15471
Taking another look now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user falaki commented on the issue:
https://github.com/apache/spark/pull/15471
@shivaram is there a chance this makes it to the 2.0.2 release?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67667/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67667 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67667/consoleFull)**
for PR 15471 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67667 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67667/consoleFull)**
for PR 15471 at commit
Github user falaki commented on the issue:
https://github.com/apache/spark/pull/15471
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67661/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67661 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67661/consoleFull)**
for PR 15471 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67661 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67661/consoleFull)**
for PR 15471 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/15471
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67602/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67602 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67602/consoleFull)**
for PR 15471 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67602 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67602/consoleFull)**
for PR 15471 at commit
Github user falaki commented on the issue:
https://github.com/apache/spark/pull/15471
@shivaram sorry for delay getting back to this. Please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user falaki commented on the issue:
https://github.com/apache/spark/pull/15471
Thanks @shivaram. I ran a real workload consisting of long running parallel
simulations that took about 3.5 hours. I also tested it by calling
`Sys.sleep()` inside workers with dapply and
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15471
sure. I think the target is 2.0.2 - it will be good to review this more
closely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/15471
@falaki @felixcheung Since this is a big change I'd like to also take a
look at this once - Will try to get to it tonight.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67287/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67287 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67287/consoleFull)**
for PR 15471 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15471
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67287 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67287/consoleFull)**
for PR 15471 at commit
Github user falaki commented on the issue:
https://github.com/apache/spark/pull/15471
Thanks @felixcheung addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67153/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67153 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67153/consoleFull)**
for PR 15471 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67153 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67153/consoleFull)**
for PR 15471 at commit
Github user falaki commented on the issue:
https://github.com/apache/spark/pull/15471
@shivaram it was indeed my fault. I did not run local tests after I added
the heartbeat. I am now using +1 for heartbeat.
---
If your project is set up for it, you can reply to this email and have
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/15471
@falaki looks like the SparkR MLlib unit tests are timing out on Jenkins.
Do they pass on your machine ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67091/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67091 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67091/consoleFull)**
for PR 15471 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67091 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67091/consoleFull)**
for PR 15471 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/15471
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user falaki commented on the issue:
https://github.com/apache/spark/pull/15471
@shivaram I think they are unrelated. Can you trigger another test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67079/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67079 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67079/consoleFull)**
for PR 15471 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/15471
@falaki Do we know if the tests timeout are due to this change ? Or are
they unrelated ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #67079 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67079/consoleFull)**
for PR 15471 at commit
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/15471
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user falaki commented on the issue:
https://github.com/apache/spark/pull/15471
@shivaram this worked on my stress tests. The question is how to unit test
this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15471
would it be possible to pull "6000" into a constant so it could be
found/changed in one shot?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66928/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #66928 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66928/consoleFull)**
for PR 15471 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #66928 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66928/consoleFull)**
for PR 15471 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66915/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15471
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #66915 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66915/consoleFull)**
for PR 15471 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15471
**[Test build #66915 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66915/consoleFull)**
for PR 15471 at commit
60 matches
Mail list logo
