Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15596
**[Test build #67492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67492/consoleFull)**
for PR 15596 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15596
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15596
**[Test build #67480 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67480/consoleFull)**
for PR 15596 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15596
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67480/
Test PASSed.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15596
> In typical operation, we don't necessarily expect CollectLimitExec to
appear in the middle of a query plan, so CollectLimitExec.execute() should
generally only be called in special cases such as
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15596
**[Test build #67480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67480/consoleFull)**
for PR 15596 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15596
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15596
For a bit of background on `CollectLimitExec`, note that the intent of this
operator is to be able to optimize the special case where a limit is the
terminal operator of a plan: in this case, we
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15596
**[Test build #67452 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67452/consoleFull)**
for PR 15596 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15596
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67452/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15596
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15596
hmmm, I don't image that it is needed for such related changes to remove
shuffle codes in CollectLimitExec.
This is not a serious issue and if you think this change is too big for the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15596
**[Test build #67452 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67452/consoleFull)**
for PR 15596 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15596
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67427/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15596
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15596
**[Test build #67427 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67427/consoleFull)**
for PR 15596 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15596
**[Test build #67427 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67427/consoleFull)**
for PR 15596 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15596
@JoshRosen could you shed some light on why we are not using the regular
`EnsureRequirements` based code path for `CollectLimitExec`?
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15596
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67371/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15596
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15596
**[Test build #67371 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67371/consoleFull)**
for PR 15596 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15596
BTW, we can see if there is an exchange added for `CollectLimit` from
physical plan, e.g.,
CollectLimit 1
+- Exchange SinglePartition
+- *LocalLimit 1
+-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15596
**[Test build #67371 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67371/consoleFull)**
for PR 15596 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15596
cc @rxin @yhuai May you take a quick look to see if this direction is ok
for you? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
24 matches
Mail list logo
