[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15618 Scratch that; it doesn't merge cleanly. Let's leave it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15618 I'm going to merge to 2.1 as well to match https://github.com/apache/spark/pull/15320 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/15618 LGTM, merging it into master. Thx @HyukjinKwon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68273/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #68273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68273/consoleFull)** for PR 15618 at commit [`d680a2f`](https://github.com/apache/spark/commit/d680a2f47f25daf2a9fe18a84fe081a688348fb9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #68273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68273/consoleFull)** for PR 15618 at commit [`d680a2f`](https://github.com/apache/spark/commit/d680a2f47f25daf2a9fe18a84fe081a688348fb9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68231/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #68231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68231/consoleFull)** for PR 15618 at commit [`a9a5f06`](https://github.com/apache/spark/commit/a9a5f061b8536c8b3173bb5701cb0de0bad99fcc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 Oh wait, it seems the failed test is related. Will take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 Ll --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67903/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67903 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67903/consoleFull)** for PR 15618 at commit [`1521572`](https://github.com/apache/spark/commit/15215722dfe2de0785d38cce5713f33fac5e4b03). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67903/consoleFull)** for PR 15618 at commit [`1521572`](https://github.com/apache/spark/commit/15215722dfe2de0785d38cce5713f33fac5e4b03). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67784/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67784 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67784/consoleFull)** for PR 15618 at commit [`49cb4e7`](https://github.com/apache/spark/commit/49cb4e7f259ba0a236b0a977e69719cfc165c265). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67784/consoleFull)** for PR 15618 at commit [`49cb4e7`](https://github.com/apache/spark/commit/49cb4e7f259ba0a236b0a977e69719cfc165c265). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 I tried to initialize it in `start()`. Could you take a look at https://github.com/apache/spark/pull/15618/commits/49cb4e7f259ba0a236b0a977e69719cfc165c265 ? (If it does not looks nice, I will definitely revert the change back) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67753/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67753/consoleFull)** for PR 15618 at commit [`3949dbe`](https://github.com/apache/spark/commit/3949dbeda632e215c64dcc089365bdc7334dacaf). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67750/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67750/consoleFull)** for PR 15618 at commit [`3949dbe`](https://github.com/apache/spark/commit/3949dbeda632e215c64dcc089365bdc7334dacaf). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67753/consoleFull)** for PR 15618 at commit [`3949dbe`](https://github.com/apache/spark/commit/3949dbeda632e215c64dcc089365bdc7334dacaf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67749/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67749 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67749/consoleFull)** for PR 15618 at commit [`3949dbe`](https://github.com/apache/spark/commit/3949dbeda632e215c64dcc089365bdc7334dacaf). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67750/consoleFull)** for PR 15618 at commit [`3949dbe`](https://github.com/apache/spark/commit/3949dbeda632e215c64dcc089365bdc7334dacaf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67749/consoleFull)** for PR 15618 at commit [`3949dbe`](https://github.com/apache/spark/commit/3949dbeda632e215c64dcc089365bdc7334dacaf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67743/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67743/consoleFull)** for PR 15618 at commit [`3949dbe`](https://github.com/apache/spark/commit/3949dbeda632e215c64dcc089365bdc7334dacaf). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67743/consoleFull)** for PR 15618 at commit [`3949dbe`](https://github.com/apache/spark/commit/3949dbeda632e215c64dcc089365bdc7334dacaf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67738/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67738/consoleFull)** for PR 15618 at commit [`3949dbe`](https://github.com/apache/spark/commit/3949dbeda632e215c64dcc089365bdc7334dacaf). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67738/consoleFull)** for PR 15618 at commit [`3949dbe`](https://github.com/apache/spark/commit/3949dbeda632e215c64dcc089365bdc7334dacaf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67654/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67654/consoleFull)** for PR 15618 at commit [`863ea7f`](https://github.com/apache/spark/commit/863ea7f66d4919a3e2c8ee6e3ca575a80a3115dc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 Could I please ask to take a look if the additional changes make sense? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67654/consoleFull)** for PR 15618 at commit [`863ea7f`](https://github.com/apache/spark/commit/863ea7f66d4919a3e2c8ee6e3ca575a80a3115dc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15618
I don't mean putting the finally here on this line since we do use it in
the success case.
But try {} catch e { handleStuff(); throw e; }
is just try {} finally {}. I think there are several ways we could
structure it that could work.
But I agree perhaps the difference is not significant at this point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 Thank you for a good reference and explanation @mridulm . I will try to handle it. (It seems I misunderstood the comments.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15618 It makes sense to use the Utils methods where possible, sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/15618 @HyukjinKwon So the idea is that you acquire resources required and dont need to track it by wrapping them in Utils.tryWithResource (similar to memory management in jvm). As an example: main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala change will simply acquire the fileInputStream in the try and release it in the finally automatically - without needing to manage it via catch/rethrow, etc (ex: what if close() throws exception ?). Even core/src/test/scala/org/apache/spark/FileSuite.scala, core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala, etc change can be modelled the same way. You get the idea :-) This is essentially analogous to try-with-resources in java. Which is not to say it applies every where ofcourse : drawback is that unlike in java, you need to explicitly specify the finally action, which can be pita imo compared to java's idiom. Since you are anyway going through the pain of making all these changes to fix up code, might be a good idea to change it such that future tests will follow the same pattern. Thoughts ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 I just took a look for `Utils.tryWithSafeFinally` and `Utils.tryWithResource`. It seems both `Utils.tryWithSafeFinally` and `Utils.tryWithResource closes it in `finally` if I understand this correctly. Could I just leave as it is? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 cc @fuzhouch too (we talk about this via emails). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 Thanks @mridulm and @felixcheung. Let me try to address your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/15618 There are a bunch of methods in Utils which actually nicely apply to this PR. * Utils.tryWithSafeFinally * Utils.tryWithResource, etc They also handle exception suppression, etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67516/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67516 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67516/consoleFull)** for PR 15618 at commit [`f3713d1`](https://github.com/apache/spark/commit/f3713d1ff59e5bd45a8a207eaf36ab8e6c285812). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 Let me take a look into this deeper of some tests constantly fail. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67516/consoleFull)** for PR 15618 at commit [`f3713d1`](https://github.com/apache/spark/commit/f3713d1ff59e5bd45a8a207eaf36ab8e6c285812). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67507/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67507 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67507/consoleFull)** for PR 15618 at commit [`f3713d1`](https://github.com/apache/spark/commit/f3713d1ff59e5bd45a8a207eaf36ab8e6c285812). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67507/consoleFull)** for PR 15618 at commit [`f3713d1`](https://github.com/apache/spark/commit/f3713d1ff59e5bd45a8a207eaf36ab8e6c285812). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67491/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15618 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67491/consoleFull)** for PR 15618 at commit [`f3713d1`](https://github.com/apache/spark/commit/f3713d1ff59e5bd45a8a207eaf36ab8e6c285812). * This patch **fails from timeout after a configured wait of \`250m\`**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15618 **[Test build #67491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67491/consoleFull)** for PR 15618 at commit [`f3713d1`](https://github.com/apache/spark/commit/f3713d1ff59e5bd45a8a207eaf36ab8e6c285812). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15618: [SPARK-14914][CORE] Fix Resource not closed after using,...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15618 This PR simply rebases https://github.com/apache/spark/pull/12693 because it seems almost there or already done but was not rebased and It has been stale. I guess this should be credited to @taoli91. cc @tdas @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
