[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15863 **[Test build #69498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69498/consoleFull)** for PR 15863 at commit [`204594f`](https://github.com/apache/spark/commit/204594f524594633cbc5902685bd6d7a24989cde). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15863 Also, cc @srowen . Sorry for the confusion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15863 **[Test build #69494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69494/consoleFull)** for PR 15863 at commit [`3323b42`](https://github.com/apache/spark/commit/3323b429990955fff9f96a311496edb57b891c6c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15863 **[Test build #69493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69493/consoleFull)** for PR 15863 at commit [`2e249ea`](https://github.com/apache/spark/commit/2e249ea06f00f814efc80524d08d17d2146cc553). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15863
Oh, it's still there.
```scala
scala> new
org.apache.spark.sql.execution.datasources.jdbc.JDBCOptions(Map("url" ->
"jdbc:mysql://localhost:3306/temp", "dbtable" -> "t1", "numPartitions" ->
"10")).asConnectionProperties
res0: java.util.Properties = {numpartitions=10}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15863 I close this PR since this is already fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15863 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68606/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15863 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15863 **[Test build #68606 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68606/consoleFull)** for PR 15863 at commit [`2e249ea`](https://github.com/apache/spark/commit/2e249ea06f00f814efc80524d08d17d2146cc553). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15863 @cloud-fan and @gatorsmile . For the `DataSource` options issue, I'm working on [SPARK-18433](https://issues.apache.org/jira/browse/SPARK-18433) for the followings. - CSVOptions - JDBCOptions - JSONOptions - OrcOptions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15863 **[Test build #68572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68572/consoleFull)** for PR 15863 at commit [`c6cf19c`](https://github.com/apache/spark/commit/c6cf19c2d73834831f95a7ae466d7d96f5380c17). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15863 I updated `DataSource` consistently to use `CaseInsensitiveMap` and am running tests. After testing, this PR will include the followings. - Fix `DataSource` to use `CaseInsensitiveMap`. - Fix `JDBCOptions.asConnectionProperties` to be case-insensitive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15863 Oh, sure. I'll investigate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15863
Not always. Try this code path.
```Scala
val df = spark.createDataFrame(sparkContext.parallelize(arr2x2),
schema2)
df.write.format("jdbc")
.option("URL", url1)
.option("dbtable", "TEST.SAVETEST")
.options(properties.asScala)
.save()
```
I think we should make them consistent. Can you fix it in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15863 Thank you for review, @gatorsmile . In the Spark code, `JDBCOption` is always receiving `CaseInsensitiveMap`. For example, here. - https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala#L237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15863 Our user-specified JDBC options/parameters are case sensitive, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15863 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68563/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15863 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15863 **[Test build #68563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68563/consoleFull)** for PR 15863 at commit [`2e249ea`](https://github.com/apache/spark/commit/2e249ea06f00f814efc80524d08d17d2146cc553). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15863 Yes. It seems not to solve this problem. The problem is the following list is case-sensitive. ``` private val jdbcOptionNames = ArrayBuffer.empty[String] ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15863 Oh, it seems not. I just removed my suggestion. I will take a look at this again if it is possible in similar way. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15863 Thank you for review, @HyukjinKwon . Let me see that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15863
Hi @dongjoon-hyun, I just happened to look at this PR and I am just
curious. Would this be possible to override `filterKeys` in
`CastInsensitiveMap` as something like below?
```scala
class CaseInsensitiveMap(map: Map[String, String]) extends Map[String,
String]
with MapLike[String, String, CaseInsensitiveMap] with Serializable {
...
override def filterKeys(p: String => Boolean): Map[String, String] = {
super.filterKeys({v: String => p(v.toLowerCase)})
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15863: [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15863 **[Test build #68563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68563/consoleFull)** for PR 15863 at commit [`2e249ea`](https://github.com/apache/spark/commit/2e249ea06f00f814efc80524d08d17d2146cc553). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
