[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16084 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16084 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16084 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69496/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16084 **[Test build #69496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69496/consoleFull)** for PR 16084 at commit [`5bcfb08`](https://github.com/apache/spark/commit/5bcfb08244572e5fef6382d04ee983ea618f734a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16084 **[Test build #69496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69496/consoleFull)** for PR 16084 at commit [`5bcfb08`](https://github.com/apache/spark/commit/5bcfb08244572e5fef6382d04ee983ea618f734a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16084 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69450/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16084 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16084 **[Test build #69450 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69450/consoleFull)** for PR 16084 at commit [`3535acf`](https://github.com/apache/spark/commit/3535acf4f84a9057f4bbb88a81e4fff5f5167c0d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16084 Yes, I noticed it before when I made a last change (avoiding the type dispatch for each record) but I just made a safe choice. It looks good to me as targeted because `JacksonParser` constructor actually takes `StructType` and `makeRootConverter` was exposed for testing purpose in `JsonSuite`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16084 **[Test build #69450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69450/consoleFull)** for PR 16084 at commit [`3535acf`](https://github.com/apache/spark/commit/3535acf4f84a9057f4bbb88a81e4fff5f5167c0d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/16084 Jenkins, this is ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user NathanHowell commented on the issue: https://github.com/apache/spark/pull/16084 cc/ @HyukjinKwon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16084: [SPARK-18654][SQL] Remove unreachable patterns in makeRo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16084 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
