[GitHub] spark issue #16556: [SPARK-19184][MLlib] Improve numerical stability for met...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16556 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16556: [SPARK-19184][MLlib] Improve numerical stability for met...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16556 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16556: [SPARK-19184][MLlib] Improve numerical stability for met...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16556 **[Test build #3529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3529/testReport)** for PR 16556 at commit [`db73727`](https://github.com/apache/spark/commit/db737275d563b6057a5b4a2f116badc1f362f2f0). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16556: [SPARK-19184][MLlib] Improve numerical stability for met...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16556 **[Test build #3529 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3529/testReport)** for PR 16556 at commit [`db73727`](https://github.com/apache/spark/commit/db737275d563b6057a5b4a2f116badc1f362f2f0). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16556: [SPARK-19184][MLlib] Improve numerical stability for met...
Github user tygert commented on the issue: https://github.com/apache/spark/pull/16556 What do you think, @srowen and @hl475, should this entail modifying Breeze in order to leverage LAPACK, or should this bug fix get accepted as it stands? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16556: [SPARK-19184][MLlib] Improve numerical stability for met...
Github user tygert commented on the issue: https://github.com/apache/spark/pull/16556 Maybe @hl475 could add his remark about how "we don't use LAPACK here since there is no pivoted QR in LAPACK that stops when the rank is exhausted" to the inline comments he highlighted? Incidentally, RSVDPACK -- https://github.com/sergeyvoronin/LowRankMatrixDecompositionCodes -- does include the necessary routine, but neither Spark nor Breeze is planning to incorporate the new RSVDPACK so far as I know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16556: [SPARK-19184][MLlib] Improve numerical stability for met...
Github user hl475 commented on the issue: https://github.com/apache/spark/pull/16556 @srowen: We donât use LAPACK here since there is no pivoted QR in LAPACK that stops when the rank is exhausted. This is highlighted in the inline comments [563 to 565](https://github.com/apache/spark/pull/16556/files#diff-00e48e38779d4534190bf78a0fd962dbR563). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16556: [SPARK-19184][MLlib] Improve numerical stability for met...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16556 Is there not a library method for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16556: [SPARK-19184][MLlib] Improve numerical stability for met...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16556 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
