[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16573 Since the log level is not stored in Spark, we cannot recover the correct level if the user just uses `org.apache.log4j.Logger.getRootLogger().setLevel(l)` to set. In addition, if I use `org.apache.log4j.Logger.getRootLogger().setLevel(l)` to set the level in my code, but Spark will change it after recovery, I would be very surprised. Hence, I suggest to not fix this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/16573 @zsxwing I know what you mean, and indeed it can achieve the right result! IMHO, since we have provided the `SparkContext.setLogLevel`, it is weird to call `org.apache.log4j.Logger.getRootLogger().setLevel(l)`, but not use `SparkContext.setLogLevel()`. Besides, the new adding conf is just an internal conf. At last, the actual change is far from complicated. Anyway, it is not a major issue, and can be fixed with your way, if you do not like this PR, I will close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16573 You can just call `org.apache.log4j.Logger.getRootLogger().setLevel(l)` in your main method before `StreamingContext.getOrCreate`. I don't think it's a good idea to add a new Spark conf just for Streaming checkpoints. In addition, it seems weird to me that Streaming also checkpoints the log level. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/16573 also cc @tdas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/16573 @zsxwing Could you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16573 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16573 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71392/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16573 **[Test build #71392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71392/testReport)** for PR 16573 at commit [`1fc5f93`](https://github.com/apache/spark/commit/1fc5f93d7bc0a3f5ab0a0920693102cac1044a8c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16573 **[Test build #71392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71392/testReport)** for PR 16573 at commit [`1fc5f93`](https://github.com/apache/spark/commit/1fc5f93d7bc0a3f5ab0a0920693102cac1044a8c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/16573 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16573 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16573 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71317/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16573 **[Test build #71317 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71317/testReport)** for PR 16573 at commit [`1fc5f93`](https://github.com/apache/spark/commit/1fc5f93d7bc0a3f5ab0a0920693102cac1044a8c). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16573: [SPARK-19210][DStream] Add log level info into checkpoin...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16573 **[Test build #71317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71317/testReport)** for PR 16573 at commit [`1fc5f93`](https://github.com/apache/spark/commit/1fc5f93d7bc0a3f5ab0a0920693102cac1044a8c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
