[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17670 Thanks! Merging to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17670 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17670 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17670 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75975/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17670 **[Test build #75975 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75975/testReport)** for PR 17670 at commit [`e940c6f`](https://github.com/apache/spark/commit/e940c6f066421cd45712ebe7149a48f7faa394ed). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17670 **[Test build #75975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75975/testReport)** for PR 17670 at commit [`e940c6f`](https://github.com/apache/spark/commit/e940c6f066421cd45712ebe7149a48f7faa394ed). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17670 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17670 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17670 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75971/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17670 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17670 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75974/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17670 **[Test build #75974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75974/testReport)** for PR 17670 at commit [`e940c6f`](https://github.com/apache/spark/commit/e940c6f066421cd45712ebe7149a48f7faa394ed). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17670 better to open another pr to backport to v2.2? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17670 LGTM except a comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17670 Ok, I am fine to keep the existing way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17670 **[Test build #75971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75971/testReport)** for PR 17670 at commit [`a65d5c6`](https://github.com/apache/spark/commit/a65d5c629a381ea2af54a2198a250590a5e43437). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17670 Looking around the related code, I think we cannot easily set `defaultParallelism` inside `catalyst.plans.logical` because there is no obvious way to access `SQLContext` there. So, IIUC, we cannot easily set the value at `numSlice` in `ResolveTableValuedFunctions `. Another approach to share the default Range `numSlice` of SparkContext APIs and SQL is that [we do not set the default value in `SparkSession`](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala#L517) and we set the default value in `RangeExec` for both cases. Thought? @jaceklaskowski @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17670 okay, I'll fix soon. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17670 As @jaceklaskowski said, it would be good to fill `numSlices` in the rule `ResolveTableValuedFunctions`, if it is None. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17670 @gatorsmile WDYT? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17670 I think the change should rather be [here](ResolveTableValuedFunctions) where the built-in table-valued function `range` is resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17670 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17670 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75900/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17670 **[Test build #75900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75900/testReport)** for PR 17670 at commit [`18360ff`](https://github.com/apache/spark/commit/18360fffa770d922e62fd29f6d3538a8036966d2). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17670 **[Test build #75900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75900/testReport)** for PR 17670 at commit [`18360ff`](https://github.com/apache/spark/commit/18360fffa770d922e62fd29f6d3538a8036966d2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
