[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18299 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78077/ Test PASSed. ---

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78077/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78077 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78077/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78071/ Test FAILed. ---

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78071/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78070/ Test FAILed. ---

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78070/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78071/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78070 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78070/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78068/ Test FAILed. ---

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78068/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/18299 LGTM except one minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/18299 Got it, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78068/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18299 The issue is that SparkSession might change the way they are wired and it's not always the case that when we create a new thread, we set the thread local conf. --- If your project is set up for it,

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/18299 Since we have a thread local variable in `SQLConf`, can we just provide getter/setter methods, get it in `QueryPlan` and set it in `SparkSession`? --- If your project is set up for it, you can reply

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78038 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78038/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78038/ Test FAILed. ---

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18299 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78036/ Test FAILed. ---

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78036/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78038/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18299 **[Test build #78036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78036/testReport)** for PR 18299 at commit

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18299 cc @wzhfy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan and expr...

2017-06-14 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18299 Note that this patch is based on https://github.com/apache/spark/pull/18298. Once we merge that one the diff will become smaller. --- If your project is set up for it, you can reply to this email