[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 @cloud-fan Thanks for update. Considering the complexity of codegen-only expressions, I guess we need significant community effort and review bandwidth in order to make all expressions support interpreted evaluation. Looks like all objects expressions such as `Invoke`, `MapObjects` are codegen-only, we need to implement interpreted versions for them all if we decide to go forward this way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18346 Sorry I'm taking this off, `CodegenFallback` may be not needed, but we do need the interpreted evaluation of expressions, see https://issues.apache.org/jira/browse/SPARK-21320 . So to fix this problem, we should make all expressions support interpreted evaluation, instead of making all expressions support codegen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 Ah, that's right. Catalyst is not public API. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18346 `CodegenFallback` is never exposed to users, Spark doesn't have an official API for customized expressions, it's all internal. You can develop customized logical plan, physical plan, expression, but then it's your own responsibility to maintain them, as you are using internal API. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 ping @cloud-fan any more feedback on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 Another concern I might have is that `CodegenFallback` is already exposed to users. So is it ok to remove it now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/18346 @cloud-fan +1 on this. This can clear up the testability issue we have when implementing `Expression` since it's challenging to test properly for both `eval` and `codegen` path. If we can consolidate the paths, it will be easier for developers to implement `Expression`. But being said that, developers may not want to implement `codegen` in some case, we probably want to have the flexibility for this use-case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 Interesting. I'd close this first if we don't have `CodegenFallback` anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18346 @dbtsai that's my proposal, and I'm going to open a JIRA to make all expression support codegen and remove `CodegenFallback`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/18346 Does it mean all the expressions **have to** implement codegen, and no `eval` any more? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18346 I mean, there should be no non-codegen expressions in the future. All expressions should be able to do codegen by passing some references to the generated code, instead of passing itself to the generated code and call `eval`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 Not sure if I understand correctly. Currently `CodegenFallback` already does codegen for non-codegen expressions via `CodegenContext.references`. So I am not sure if we don't have an adapter like `CodegenFallback`, how do we evaluate non-codegen expressions in codegen? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18346 I think eventually we should remove `CodegenFallback`. With `CodegenContext.addReferenceObj`, we can codegen everything, and we can even remove `Expression.eval` at some point. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 Btw, even we can evaluate all children expressions of `CodegenFallback` with codegen path, we still can't do wholestage codegen with the plans including `CodegenFallback` expressions. We just can do expression codegen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 Thanks @dbtsai for the comment. Yeah, I've also tried to let `CodegenFallback` evaluate all its children under codegen path in parallel with this PR. It works. Of course the advantage of the alternative approach is the performance. I didn't submit that approach is because it adds additional APIs to `CodegenFallback`. So it requires users to slightly re-write their `CodegenFallback` based expressions to avoid this issue. Another concern is we don't have too much codgen-only expressions in Spark, most of them are object expressions. It might be rare to have codegen-only expressions under `CodegenFallback`. So I am not sure if it is worth to add APIs into `CodegenFallback`. If we reach an agreement here, I will submit the alternative approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/18346
Thanks, @viirya for this PR.
We hit this issue, and @viirya was kindly helping us to find the root
cause. This approach LGTM. One alternative approach we took in the end to
unblock our use-case is having the CodeGenFallback to generate the code for all
the children instead of going through the eval paths, and this works for us. I
think the approach we took have benefits that we still can do the wholestage
codegen together with the expression with CodeGenFallback without separating
them into different path.
@gatorsmile @cloud-fan any feedback?
Thanks.
```scala
import org.apache.spark.sql.catalyst.expressions.{Expression,
LeafExpression, Nondeterministic, TernaryExpression}
import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext,
ExprCode}
trait TernaryCodegenFallback extends Expression { self: TernaryExpression =>
private val className = classOf[TernaryCodegenFallback].getName
def evalFromCodegen(value1: Any, value2: Any, value3: Any): Any =
nullSafeEval(value1, value2, value3)
protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
foreach {
case n: Nondeterministic => n.setInitialValues()
case _ =>
}
// LeafNode does not need `input`
val input = if (this.isInstanceOf[LeafExpression]) "null" else
ctx.INPUT_ROW
val idx = ctx.references.length
ctx.references += this
val objectTerm = ctx.freshName("obj")
val placeHolder = ctx.registerComment(this.toString)
val Seq(code1, code2, code3) = children.map(expr => expr.genCode(ctx))
if (nullable) {
ev.copy(code = s"""
$placeHolder
${code1.code}
${code2.code}
${code3.code}
Object $objectTerm = null;
boolean ${ev.isNull} = ${code1.isNull} || ${code2.isNull} ||
${code3.isNull};
if (!${ev.isNull}) {
$objectTerm = (($className) references[$idx]).evalFromCodegen(
${code1.value}, ${code2.value}, ${code3.value}
);
${ev.isNull} = $objectTerm == null;
}
${ctx.javaType(this.dataType)} ${ev.value} =
${ctx.defaultValue(this.dataType)};
if (!${ev.isNull}) {
${ev.value} = (${ctx.boxedType(this.dataType)}) $objectTerm;
}""")
} else {
ev.copy(code = s"""
$placeHolder
${code1.code}
${code2.code}
${code3.code}
Object $objectTerm = (($className)
references[$idx]).evalFromCodegen(
${code1.value}, ${code2.value}, ${code3.value}
);
${ctx.javaType(this.dataType)} ${ev.value} =
(${ctx.boxedType(this.dataType)}) $objectTerm;
""", isNull = "false")
}
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 cc @cloud-fan @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18346 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18346 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18346 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78238/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18346 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78237/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18346 **[Test build #78238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78238/testReport)** for PR 18346 at commit [`c2783f4`](https://github.com/apache/spark/commit/c2783f4bd3f50a1e0583276155df8d40ec3c1d55). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait CodegenOnlyExpression extends Expression ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18346 **[Test build #78237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78237/testReport)** for PR 18346 at commit [`4f412b7`](https://github.com/apache/spark/commit/4f412b7d6b15f563c67c7cf12392798b88146fcf). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait CodegenOnlyExpression extends Expression ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18346 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78236/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18346 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18346 **[Test build #78236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78236/testReport)** for PR 18346 at commit [`eead5e1`](https://github.com/apache/spark/commit/eead5e106f13a593e64a1c1d440bd66e2fbac48b). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait CodegenOnlyExpression extends Expression ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18346 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18346 **[Test build #78234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78234/testReport)** for PR 18346 at commit [`b79fc42`](https://github.com/apache/spark/commit/b79fc4272bd09f6d2469c6a36bac4ebfe0b9abfe). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait CodegenOnlyExpression extends Expression ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18346 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78234/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18346 **[Test build #78238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78238/testReport)** for PR 18346 at commit [`c2783f4`](https://github.com/apache/spark/commit/c2783f4bd3f50a1e0583276155df8d40ec3c1d55). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18346 **[Test build #78237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78237/testReport)** for PR 18346 at commit [`4f412b7`](https://github.com/apache/spark/commit/4f412b7d6b15f563c67c7cf12392798b88146fcf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18346 **[Test build #78236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78236/testReport)** for PR 18346 at commit [`eead5e1`](https://github.com/apache/spark/commit/eead5e106f13a593e64a1c1d440bd66e2fbac48b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 cc @dbtsai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18346 **[Test build #78234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78234/testReport)** for PR 18346 at commit [`b79fc42`](https://github.com/apache/spark/commit/b79fc4272bd09f6d2469c6a36bac4ebfe0b9abfe). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
