[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18831 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18831 Thanks both for the comments. Yes, I think it's be to keep this PR on offset and we can address the other improvements later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/18831 @felixcheung Sorry for misunderstand, I agree we can support ```df$myoffset``` as well, the requirement make sense for R users. Let's create a separate JIRA to track it and do this change for other similar arguments like ```weightCol``` as well. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18831 To be clear, I'm not suggesting to rename the parameter. I'm suggest we should support the type being passed in as column like df$myoffset in addition to it being a string. This will be more R like --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18831 Thanks for your comments, Felix. Addressed all issues. @yanboliang Could you take a quick look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18831 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80219/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18831 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18831 **[Test build #80219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80219/testReport)** for PR 18831 at commit [`3c4ebf9`](https://github.com/apache/spark/commit/3c4ebf9df54a2e54684b2da5ea977b5d3255b62a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18831 **[Test build #80219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80219/testReport)** for PR 18831 at commit [`3c4ebf9`](https://github.com/apache/spark/commit/3c4ebf9df54a2e54684b2da5ea977b5d3255b62a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18831 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80218/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18831 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18831 **[Test build #80218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80218/testReport)** for PR 18831 at commit [`dc8ccbc`](https://github.com/apache/spark/commit/dc8ccbc19b93b527898f9d20ba71228c3c8c895e). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18831 **[Test build #80218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80218/testReport)** for PR 18831 at commit [`dc8ccbc`](https://github.com/apache/spark/commit/dc8ccbc19b93b527898f9d20ba71228c3c8c895e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18831 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80213/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18831 **[Test build #80213 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80213/testReport)** for PR 18831 at commit [`6ec068e`](https://github.com/apache/spark/commit/6ec068e5f48d393d539f4600bca3cbd1ea7d65a3). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18831 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18831 **[Test build #80213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80213/testReport)** for PR 18831 at commit [`6ec068e`](https://github.com/apache/spark/commit/6ec068e5f48d393d539f4600bca3cbd1ea7d65a3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18831 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18831 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80194/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18831 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18831 **[Test build #80194 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80194/testReport)** for PR 18831 at commit [`6ec068e`](https://github.com/apache/spark/commit/6ec068e5f48d393d539f4600bca3cbd1ea7d65a3). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18831: [SPARK-21622][ML][SparkR] Support offset in SparkR GLM
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18831 **[Test build #80194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80194/testReport)** for PR 18831 at commit [`6ec068e`](https://github.com/apache/spark/commit/6ec068e5f48d393d539f4600bca3cbd1ea7d65a3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
