[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18837 There are still some small issues (minor style nits, duplicating conf keys instead of using `CONSTANT.key`), but well. I can't really comment on the functionality itself so I'll trust your guys' judgement since you're way more familiar with Mesos. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user ArtRand commented on the issue: https://github.com/apache/spark/pull/18837 Hello @vanzin should be consistent now. Thanks again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user ArtRand commented on the issue: https://github.com/apache/spark/pull/18837 Hello @vanzin, thanks for the review. I added `.toSequence` to the new configuration specs, certainly a nice solution to parsing on the fly. Please let me know if there is anything else that needs changing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18837 **[Test build #3904 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3904/testReport)** for PR 18837 at commit [`e28f201`](https://github.com/apache/spark/commit/e28f2011cb71ef8a3638732fdd9cc4e536bbd993). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18837 **[Test build #3904 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3904/testReport)** for PR 18837 at commit [`e28f201`](https://github.com/apache/spark/commit/e28f2011cb71ef8a3638732fdd9cc4e536bbd993). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user ArtRand commented on the issue: https://github.com/apache/spark/pull/18837 Hello @srowen, thanks for taking a look at this. You're correct in that this change does not require users to have a Mesos 1.3+ cluster, we do not change or omit any required records in the proto (https://github.com/apache/mesos/blob/1.3.0/include/mesos/mesos.proto#L2053). If a user tries to specify a secret on an older cluster, the additional (optional) records should be ignored. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user ArtRand commented on the issue: https://github.com/apache/spark/pull/18837 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18837 **[Test build #3900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3900/testReport)** for PR 18837 at commit [`4d65bfc`](https://github.com/apache/spark/commit/4d65bfcff11183fcdc746267af206c947684d15f). * This patch **fails build dependency tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18837 **[Test build #3900 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3900/testReport)** for PR 18837 at commit [`4d65bfc`](https://github.com/apache/spark/commit/4d65bfcff11183fcdc746267af206c947684d15f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user ArtRand commented on the issue: https://github.com/apache/spark/pull/18837 Hello @vanzin and @srowen, not trying to be a pest, but I would really appreciate a review on this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user ArtRand commented on the issue: https://github.com/apache/spark/pull/18837 Hello @srowen could you have a look at this (and green light the testing) when you have a chance? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18837: [Spark-20812][Mesos] Add secrets support to the dispatch...
Github user skonto commented on the issue: https://github.com/apache/spark/pull/18837 Btw a lot of secrets are defined in the code base: spark.secret.mesos,spark.mesos.driver.secret.name, spark.authenticate.secret (https://spark.apache.org/docs/latest/security.html) do you think docs need improvement? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
