[GitHub] spark issue #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fails for...

2017-08-07 Thread eyalfa
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/18855 @HyukjinKwon , interesting reading but I couldn't find a concrete reason or solution to the issue. @cloud-fan, I've encountered this bug when working with a disk persisted RDD, it turned out some

[GitHub] spark issue #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fails for...

2017-08-07 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18855 Sounds good to me except `BlockManagerSuite.scala`. I am not familiar whether this new test checks new code well or not. --- If your project is set up for it, you can reply to this email and have you

[GitHub] spark issue #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fails for...

2017-08-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18855 Looks reasonable, can you explain which end-to-end cases this patch fixed? and also which end-to-end cases remain problematic. --- If your project is set up for it, you can reply to this email an

[GitHub] spark issue #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fails for...

2017-08-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18855 Yea, please refer http://apache-spark-developers-list.1001551.n3.nabble.com/Some-PRs-not-automatically-linked-to-JIRAs-td22067.html Looks some problems related with it. --- If your project is

[GitHub] spark issue #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fails for...

2017-08-06 Thread eyalfa
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/18855 @kiszk , fixed styling+readability according to your comments. BTW, any idea why JIRA didn't associate this PR with SPARK-3151? --- If your project is set up for it, you can reply to this email a

[GitHub] spark issue #18855: [Spark 3151][Block Manager] DiskStore.getBytes fails for...

2017-08-05 Thread eyalfa
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/18855 @rxin, @JoshRosen , @cloud-fan , you seem to be the last guys to touch this class, can you please review? --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark issue #18855: [Spark 3151][Block Manager] DiskStore.getBytes fails for...

2017-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18855 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat