[GitHub] spark issue #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fails for...
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/18855 @HyukjinKwon , interesting reading but I couldn't find a concrete reason or solution to the issue. @cloud-fan, I've encountered this bug when working with a disk persisted RDD, it turned out some of our partitions exceeded the 2GB limit and failed on `DiskStore.getBytes`. since we're using a specific commercial distro I couldn't test this patch on my use case (we got rid of the large partitions anyway by tuning number of partitions and tweaking the DAG altogether :sunglasses: ), so I did the next best thing: reproduce the issue in a test case, please see test "blocks larger than 2gb" in `DiskStoreSuite` inthis PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fails for...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18855 Sounds good to me except `BlockManagerSuite.scala`. I am not familiar whether this new test checks new code well or not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fails for...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18855 Looks reasonable, can you explain which end-to-end cases this patch fixed? and also which end-to-end cases remain problematic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fails for...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18855 Yea, please refer http://apache-spark-developers-list.1001551.n3.nabble.com/Some-PRs-not-automatically-linked-to-JIRAs-td22067.html Looks some problems related with it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18855: [SPARK-3151][Block Manager] DiskStore.getBytes fails for...
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/18855 @kiszk , fixed styling+readability according to your comments. BTW, any idea why JIRA didn't associate this PR with SPARK-3151? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18855: [Spark 3151][Block Manager] DiskStore.getBytes fails for...
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/18855 @rxin, @JoshRosen , @cloud-fan , you seem to be the last guys to touch this class, can you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18855: [Spark 3151][Block Manager] DiskStore.getBytes fails for...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18855 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
