[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18884 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18884 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80493/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18884 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18884 **[Test build #80493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80493/testReport)** for PR 18884 at commit [`7ec545b`](https://github.com/apache/spark/commit/7ec545b43b994d668a0c16d788521c4ceedb17e7). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait WriteJobStatsTracker extends Serializable ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18884 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18884 **[Test build #80493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80493/testReport)** for PR 18884 at commit [`7ec545b`](https://github.com/apache/spark/commit/7ec545b43b994d668a0c16d788521c4ceedb17e7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18884 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18884 LGTM except some minor comments, great clean up! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18884 this looks good to me, but I didn't review super carefully. cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18884 **[Test build #3885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3885/testReport)** for PR 18884 at commit [`3665f2f`](https://github.com/apache/spark/commit/3665f2fb4331012a022e9ae70cbe3d480ab8dcd3). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18884 **[Test build #3885 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3885/testReport)** for PR 18884 at commit [`3665f2f`](https://github.com/apache/spark/commit/3665f2fb4331012a022e9ae70cbe3d480ab8dcd3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18884 Jenkins, add to white list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18884: [SPARK-21669] Internal API for collecting metrics/stats ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18884 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
