Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19419
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82878/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82878 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82878/testReport)**
for PR 19419 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82876/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82876 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82876/testReport)**
for PR 19419 at commit
Github user krishna-pandey commented on the issue:
https://github.com/apache/spark/pull/19419
@srowen @rxin Made changes to enable the X-Content-Type-Options and
X-XSS-Protection values by default. Please review.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82878 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82878/testReport)**
for PR 19419 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82876 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82876/testReport)**
for PR 19419 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19419
For the content type header, does the UI seem to work normally with it on?
I don't think we should have any problem with that restriction or else need to
fix it . You could move the defaults to on
Github user krishna-pandey commented on the issue:
https://github.com/apache/spark/pull/19419
@rxin , @srowen I think we can enable X-XSS-Protection and
X-Content-Type-Options response header by default. STS Header can be left
configurable or enabled by default when Spark UI is
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19419
Yea in general for security features it seems like it's good to turn on
them by default.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82807/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82807 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82807/testReport)**
for PR 19419 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19419
The downside of additional header traffic is trivial. I suppose it is not
needed in most contexts so it was conservative to leave it off by default. That
said I am not aware of any particular
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19419
Is there a reason why this cannot be always enabled?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82807 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82807/testReport)**
for PR 19419 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82795/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82795 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82795/testReport)**
for PR 19419 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82791/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82791 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82791/testReport)**
for PR 19419 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19419
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82795 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82795/testReport)**
for PR 19419 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82791 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82791/testReport)**
for PR 19419 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #3947 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3947/testReport)**
for PR 19419 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #3947 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3947/testReport)**
for PR 19419 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82742/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82742 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82742/testReport)**
for PR 19419 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82742 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82742/testReport)**
for PR 19419 at commit
Github user krishna-pandey commented on the issue:
https://github.com/apache/spark/pull/19419
@jerryshao removed Whitespace at end of line 440 in package.scala. ok to
test.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82741/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82741 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82741/testReport)**
for PR 19419 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82741 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82741/testReport)**
for PR 19419 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82737 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82737/testReport)**
for PR 19419 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82737/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82737/testReport)**
for PR 19419 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19419
>/home/jenkins/workspace/SparkPullRequestBuilder@2/core/src/main/scala/org/apache/spark/internal/config/package.scala:440:0:
Whitespace at end of line
Please fix the style issue.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82736/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82736 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82736/testReport)**
for PR 19419 at commit
Github user krishna-pandey commented on the issue:
https://github.com/apache/spark/pull/19419
@srowen @tgravescs @dongjoon-hyun @jerryshao
Please review the PR. I have incorporated all changes as suggested.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #82736 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82736/testReport)**
for PR 19419 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19419
ok to test.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user krishna-pandey commented on the issue:
https://github.com/apache/spark/pull/19419
@tgravescs These generic headers are about providing available client-side
protection for the application. I also think even if there is no sensitive data
to formulate an attack by itself
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/19419
overall I think the headers are fine, more security the better. I'm not
exactly sure the attack vector with the spark UI though. Normally I would
expect your UI to be on a corporate network and
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19419
I think the change is OK, to give a mechanism to set these headers if
desired. There are still several comments to address though.
---
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19419
@vanzin @tgravescs @ajbozarth what is your opinion on this PR? Is it a
necessary fix for Spark?
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #3944 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3944/testReport)**
for PR 19419 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19419
**[Test build #3944 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3944/testReport)**
for PR 19419 at commit
Github user krishna-pandey commented on the issue:
https://github.com/apache/spark/pull/19419
@dongjoon-hyun Made the changes as suggested.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user krishna-pandey commented on the issue:
https://github.com/apache/spark/pull/19419
@dongjoon-hyun Thanks for the review. Made the changes as suggested.
---
-
To unsubscribe, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19419
I can see them from the browser.
LGTM except two minor comments, @krishna-pandey .
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19419
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
60 matches
Mail list logo
