[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19782 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19782 Thank you @viirya and @ueshin. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19782 LGTM too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/19782 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19782 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83999/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19782 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19782 **[Test build #83999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83999/testReport)** for PR 19782 at commit [`f41698e`](https://github.com/apache/spark/commit/f41698e330c517830a90309a022b072ea6406dcb). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19782 Looks like a fair config as we seems don't have a way to disable daemon usage. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19782 **[Test build #83999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83999/testReport)** for PR 19782 at commit [`f41698e`](https://github.com/apache/spark/commit/f41698e330c517830a90309a022b072ea6406dcb). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19782 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19782 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83993/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19782 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19782 **[Test build #83993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83993/testReport)** for PR 19782 at commit [`f41698e`](https://github.com/apache/spark/commit/f41698e330c517830a90309a022b072ea6406dcb). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19782 **[Test build #83993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83993/testReport)** for PR 19782 at commit [`f41698e`](https://github.com/apache/spark/commit/f41698e330c517830a90309a022b072ea6406dcb). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19782 cc @ueshin, could you take a look please when you have some time? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19782: [SPARK-22554][PYTHON] Add a config to control if PySpark...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19782 This is also partly for running Python coverage without extra code change. I know a hacky way to run this (see https://github.com/apache/spark/pull/19630#issuecomment-345490662 and https://github.com/apache/spark/pull/19630#issuecomment-345171997): Now, we can do, for example, as below: ``` pip install coverage # Build Spark (http://spark.apache.org/docs/latest/building-spark.html) rm python/lib/pyspark.zip rm -fr .coverage rm -fr coverage_html echo "spark.python.use.daemon false" >> conf/spark-defaults.conf echo " #!/usr/bin/env bash coverage run -p \$@ " > coverage_python chmod 755 coverage_python # Run actual Python tests PATH=`pwd`:$PATH PYSPARK_PYTHON=coverage_python SPARK_TESTING=1 bin/pyspark pyspark.sql.tests VectorizedUDFTests rm conf/spark-defaults.conf coverage combine coverage html -d coverage_html -i open coverage_html # Open up index.html in your browser. ``` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
