[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20247 Thanks! Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86108/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86108/testReport)** for PR 20247 at commit [`459170f`](https://github.com/apache/spark/commit/459170f36aa9898fc31884e669f67b92af1d76a6). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86108/testReport)** for PR 20247 at commit [`459170f`](https://github.com/apache/spark/commit/459170f36aa9898fc31884e669f67b92af1d76a6). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20247 LGTM except a minor comment. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86092/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86092 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86092/testReport)** for PR 20247 at commit [`1bc4d75`](https://github.com/apache/spark/commit/1bc4d75ceee8e039530c9d62c014b4a8dea00c51). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86091/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86091/testReport)** for PR 20247 at commit [`adeb86b`](https://github.com/apache/spark/commit/adeb86b0582a2c36e69ca1d1fc51f1eebe962354). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86092/testReport)** for PR 20247 at commit [`1bc4d75`](https://github.com/apache/spark/commit/1bc4d75ceee8e039530c9d62c014b4a8dea00c51). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86091/testReport)** for PR 20247 at commit [`adeb86b`](https://github.com/apache/spark/commit/adeb86b0582a2c36e69ca1d1fc51f1eebe962354). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20247 Welcome to Japan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20247 @maropu Yeah, I'm in Japan now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20247 Could you check? @viirya @cloud-fan (btw, I'm bit surprise @viirya moved to fukuoka?) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20247 @rednaxelafx yea, I'm also ok to print `AnalysisBarrier` cuz this info is some informative. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86078/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86078/testReport)** for PR 20247 at commit [`7692099`](https://github.com/apache/spark/commit/7692099c42907682a5ca10fa6a800fcb1a6e745d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86078/testReport)** for PR 20247 at commit [`7692099`](https://github.com/apache/spark/commit/7692099c42907682a5ca10fa6a800fcb1a6e745d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20247 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86056/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86056 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86056/testReport)** for PR 20247 at commit [`7692099`](https://github.com/apache/spark/commit/7692099c42907682a5ca10fa6a800fcb1a6e745d). * This patch **fails from timeout after a configured wait of \`300m\`**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86056 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86056/testReport)** for PR 20247 at commit [`7692099`](https://github.com/apache/spark/commit/7692099c42907682a5ca10fa6a800fcb1a6e745d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20247 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20247 Because AnalysisBarrier will be removed in analyzed plan, maybe leaving it in parsed plan is ok. This fix is more simple. But if any one thinks it is necessary to remove it from parsed plan too, I'm also ok. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/20247 Thanks for fixing it! One thing I'm curious what others think is, whether or not the `AnalysisBarrier` nodes themselves should show up in the explain output at all, i.e. should it behave more like `WholeStageCodegenExec`/`InputAdapter` in physical plans that just hides themselves from the explain output, or just show up as a normal node. I'm okay either way. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86039/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86039 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86039/testReport)** for PR 20247 at commit [`7692099`](https://github.com/apache/spark/commit/7692099c42907682a5ca10fa6a800fcb1a6e745d). * This patch **fails from timeout after a configured wait of \`250m\`**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86039/testReport)** for PR 20247 at commit [`7692099`](https://github.com/apache/spark/commit/7692099c42907682a5ca10fa6a800fcb1a6e745d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
