Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
Thanks @squito. Will merge this one in few days.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20424
still lgtm, thanks
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/20424
@squito We made a few adjustments since your "lgtm". Do you want to take a
quick look? @HyukjinKwon also gave his "lgtm" after the adjustments.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87479/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87479 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87479/testReport)**
for PR 20424 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87479/testReport)**
for PR 20424 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
Sure, you can. retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/20424
The test that finished last succeeded, but the one that started last had a
spurious error. Can I get a retest?
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87459/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87459 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87459/testReport)**
for PR 20424 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87461/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87461 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87461/testReport)**
for PR 20424 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87461 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87461/testReport)**
for PR 20424 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
LGTM!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87459 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87459/testReport)**
for PR 20424 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
Thank you @squito .. LGTM otherwise.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20424
ah got it. sounds good to me, I will defer to @HyukjinKwon 's judgement.
I think this change looks fine
---
-
To unsubscribe,
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/20424
@squito
>you mentioned wanting to try the other route as well
That was this PR: https://github.com/apache/spark/pull/20519
@HyukjinKwon would prefer to go with the
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20424
lgtm
@bersprockets you mentioned wanting to try the other route as well -- whats
the status on that? shoudl we still wait on this one?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87389/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87389 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87389/testReport)**
for PR 20424 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87389 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87389/testReport)**
for PR 20424 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87377/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87377 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87377/testReport)**
for PR 20424 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
Will take a final look for this if we are all fine with this for now.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87377 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87377/testReport)**
for PR 20424 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87362/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87362 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87362/testReport)**
for PR 20424 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87362/testReport)**
for PR 20424 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87179/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87179 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87179/testReport)**
for PR 20424 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #87179 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87179/testReport)**
for PR 20424 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
Yup, makes sense.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/20424
@HyukjinKwon @squito
Before merging this, allow me make an alternative PR that actually bypasses
the problem (rather than simply reporting on the problem). If it seems like the
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/20424
Hi @HyukjinKwon
>Do you guys have some more information to add in the error message?
If we go with this solution, I would like to improve the message before the
PR is merged.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
So, I think I am fine. I believe it's already a corner case and I think we
don't have to put a lot of efforts on this ... to be honest. I only wanted to
double check if there is a slight step
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86787/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #86787 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86787/testReport)**
for PR 20424 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
LGTM except two nits and one question.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #86787 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86787/testReport)**
for PR 20424 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
Ah, OK. fixing the error message is fine as a separate improvement.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86782/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #86782 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86782/testReport)**
for PR 20424 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20424
**[Test build #86782 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86782/testReport)**
for PR 20424 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20424
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20424
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
60 matches
Mail list logo
