[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20498 LGTM Thanks! Merged to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87050/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20498 **[Test build #87050 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87050/testReport)** for PR 20498 at commit [`aee5a55`](https://github.com/apache/spark/commit/aee5a55a2f8292a3cc1e219b7c33ade44de13093). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20498 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20498 **[Test build #87050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87050/testReport)** for PR 20498 at commit [`aee5a55`](https://github.com/apache/spark/commit/aee5a55a2f8292a3cc1e219b7c33ade44de13093). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/575/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87041/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20498 **[Test build #87041 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87041/testReport)** for PR 20498 at commit [`dac2dc8`](https://github.com/apache/spark/commit/dac2dc875107aea3fec7e4d2879a6737baabe09b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/570/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20498 **[Test build #87041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87041/testReport)** for PR 20498 at commit [`dac2dc8`](https://github.com/apache/spark/commit/dac2dc875107aea3fec7e4d2879a6737baabe09b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20498 Yes sure,I'll rebase my PR after this is merged. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20498 If possible, I prefer to doing it in this PR. We should merge this test-only PR to 2.3 and master for verifying the behavior of the changes made in 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20498 @gatorsmile yes, I see what you mean, we should keep it to check that changing `spark.sql.decimalOperations.allowPrecisionLoss` doesn't affect this case, you are right. I will comment on my PR and update it accordingly if you agree, thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20498 @mgaido91 If we remove it, we still need test cases for verifying the effects of `spark.sql.decimalOperations.allowPrecisionLoss`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20498 @gatorsmile because this is an example of overflow, ie. what is covered in the new PR: in the new PR I added many tests for this case, so I felt this unnecessary. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20498 @mgaido91 We just remove this test case? I think we can still keep it, right? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20498 @wangyum yes, you're right. I don't know how I missed it, I am very sorry for my mistake. Anyway, this is fixed also in this PR #20350, which is the "second part" of making Spark SQL-2011 compliant for decimal operations. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87035/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20498 **[Test build #87035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87035/testReport)** for PR 20498 at commit [`2f532ea`](https://github.com/apache/spark/commit/2f532ea3316f8a3058f517b405811f8c8c080309). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87034/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20498 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeticOperat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20498 **[Test build #87034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87034/testReport)** for PR 20498 at commit [`2f532ea`](https://github.com/apache/spark/commit/2f532ea3316f8a3058f517b405811f8c8c080309). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
