[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-15 Thread rkrzr
Github user rkrzr commented on the issue:

https://github.com/apache/spark/pull/20607
  
I'll close this for now. (I am running into a problem related to this, but 
I'll better open a new issue about that when I know more)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-15 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/20607
  
@rkrzr please close the PR, unless you plan to actually test that this is 
not an issue anymore.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-14 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/20607
  
Most probably nobody bothered to check.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-14 Thread rkrzr
Github user rkrzr commented on the issue:

https://github.com/apache/spark/pull/20607
  
> SPARK-3015 was fixed by setting the config to true. So by setting it to 
false you'd be unfixing it, no?

Oh, my bad. You're right. I had only seen that it had been resolved, but 
not that this was the actual fix.

The [original issue](https://github.com/apache/spark/pull/1931/files) 
states that "This is intended to be only a temporary workaround for the issue". 
This was 3,5 years ago, so I wonder if the underlying issue has perhaps changed 
in the meantime?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-14 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/20607
  
SPARK-3015 was fixed by setting the config to true. So by setting it to 
false you'd be unfixing it, no?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20607
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20607: Don't block on cleanup tasks by default

2018-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20607
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org