Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20726
Btw, I think the title should be `[SQL]` instead of `[CORE]`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
F
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20726
LGTM with one trivial doc point.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mai
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87980/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87980 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87980/testReport)**
for PR 20726 at commit
[`f637476`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87979/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87979 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87979/testReport)**
for PR 20726 at commit
[`f637476`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87975/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87975 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87975/testReport)**
for PR 20726 at commit
[`f637476`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87980 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87980/testReport)**
for PR 20726 at commit
[`f637476`](https://github.com/apache/spark/commit/f6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87970/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87979 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87979/testReport)**
for PR 20726 at commit
[`f637476`](https://github.com/apache/spark/commit/f6
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/20726
^ known flaky test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87970 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87970/testReport)**
for PR 20726 at commit
[`a27957a`](https://github.com/apache/spark/commit/a
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/20726
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87973/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87973 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87973/testReport)**
for PR 20726 at commit
[`ccadd45`](https://github.com/apache/spark/commit/c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87975 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87975/testReport)**
for PR 20726 at commit
[`f637476`](https://github.com/apache/spark/commit/f6
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/20726
Looks good to me other than a minor point on the private `readerFactories`
val.
---
-
To unsubscribe, e-mail: reviews-unsubscr...
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87973 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87973/testReport)**
for PR 20726 at commit
[`ccadd45`](https://github.com/apache/spark/commit/cc
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20726
LGTM except one comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: rev
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/20726
I think both failures don't reflect a deeper problem:
* The first was because columnar batch scans silently shortcutted around
the readerFactories lazy val, and would error out if it wer
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87970 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87970/testReport)**
for PR 20726 at commit
[`a27957a`](https://github.com/apache/spark/commit/a2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87924/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87924 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87924/testReport)**
for PR 20726 at commit
[`efb8397`](https://github.com/apache/spark/commit/e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20726
**[Test build #87924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87924/testReport)**
for PR 20726 at commit
[`efb8397`](https://github.com/apache/spark/commit/ef
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20726
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/20726
@cloud-fan @rdblue
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
33 matches
Mail list logo