[GitHub] spark issue #20825: add impurity stats in tree leaf node debug string

2018-04-06 Thread jkbradley
Github user jkbradley commented on the issue:

https://github.com/apache/spark/pull/20825
  
I actually would prefer not to merge this change since it could blow up the 
size of the strings printed for some classification tasks with large numbers of 
labels.  If people want to debug, they could trace through the tree manually.

Alternatively, I'd be OK with adding an optional argument which tells 
toDebugString to include the stats.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20825: add impurity stats in tree leaf node debug string

2018-03-15 Thread davies
Github user davies commented on the issue:

https://github.com/apache/spark/pull/20825
  
cc @zsxwing 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20825: add impurity stats in tree leaf node debug string

2018-03-14 Thread davies
Github user davies commented on the issue:

https://github.com/apache/spark/pull/20825
  
LGTM


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20825: add impurity stats in tree leaf node debug string

2018-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20825
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20825: add impurity stats in tree leaf node debug string

2018-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20825
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org