[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-11 Thread rxin
Github user rxin commented on the issue:

https://github.com/apache/spark/pull/21054
  
There is not a single function that can’t be called by expr. It mainly 
adds
some type safety.

On Fri, May 11, 2018 at 7:18 PM Hyukjin Kwon 
wrote:

> *@HyukjinKwon* commented on this pull request.
> --
>
> In sql/core/src/main/scala/org/apache/spark/sql/functions.scala
> :
>
> > @@ -775,6 +775,178 @@ object functions {
> */
>def var_pop(columnName: String): Column = var_pop(Column(columnName))
>
> +  /**
> +   * Aggregate function: returns the number of non-null pairs.
> +   *
> +   * @group agg_funcs
> +   * @since 2.4.0
> +   */
> +  def regr_count(y: Column, x: Column): Column = withAggregateFunction {
>
> @rxin , how about splitting up this file by the
> group or something, or deprecating all the functions that can be called 
via
> expr for 3.0.0? To me, it looked a bit odd when some functions exist and
> some did not. It was an actual use case and I had to check which function
> exists or not every time.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread ueshin
Github user ueshin commented on the issue:

https://github.com/apache/spark/pull/21054
  
Thanks! merging to master.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90443/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #90443 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90443/testReport)**
 for PR 21054 at commit 
[`e584adf`](https://github.com/apache/spark/commit/e584adfb972a4d56acd6f222f1c5a7affc1224a6).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #90443 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90443/testReport)**
 for PR 21054 at commit 
[`e584adf`](https://github.com/apache/spark/commit/e584adfb972a4d56acd6f222f1c5a7affc1224a6).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3098/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread ueshin
Github user ueshin commented on the issue:

https://github.com/apache/spark/pull/21054
  
Jenkins, retest this please.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90442/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-10 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #90442 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90442/testReport)**
 for PR 21054 at commit 
[`e584adf`](https://github.com/apache/spark/commit/e584adfb972a4d56acd6f222f1c5a7affc1224a6).
 * This patch **fails due to an unknown error code, -9**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3097/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #90442 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90442/testReport)**
 for PR 21054 at commit 
[`e584adf`](https://github.com/apache/spark/commit/e584adfb972a4d56acd6f222f1c5a7affc1224a6).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-09 Thread ueshin
Github user ueshin commented on the issue:

https://github.com/apache/spark/pull/21054
  
LGTM, but I'd retrigger the build because it's been some time since the 
last build.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-09 Thread ueshin
Github user ueshin commented on the issue:

https://github.com/apache/spark/pull/21054
  
Jenkins, retest this please.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90121/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #90121 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90121/testReport)**
 for PR 21054 at commit 
[`e584adf`](https://github.com/apache/spark/commit/e584adfb972a4d56acd6f222f1c5a7affc1224a6).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2864/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #90121 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90121/testReport)**
 for PR 21054 at commit 
[`e584adf`](https://github.com/apache/spark/commit/e584adfb972a4d56acd6f222f1c5a7affc1224a6).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/21054
  
@mgaido91 @ueshin Let us keep our behavior unchanged, although our outputs 
are different from Hive.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90051/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #90051 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90051/testReport)**
 for PR 21054 at commit 
[`0d8cb46`](https://github.com/apache/spark/commit/0d8cb46ccf8cee7ba9d5c55d4cfef8f3011ece2c).
 * This patch **fails SparkR unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90045/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #90045 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90045/testReport)**
 for PR 21054 at commit 
[`89295e6`](https://github.com/apache/spark/commit/89295e645e9aeea6ef7d47f35930215953a749d4).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread mgaido91
Github user mgaido91 commented on the issue:

https://github.com/apache/spark/pull/21054
  
@ueshin thank you for your attention.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread ueshin
Github user ueshin commented on the issue:

https://github.com/apache/spark/pull/21054
  
@mgaido91 Thanks for letting us know! cc @gatorsmile 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2807/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #90051 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90051/testReport)**
 for PR 21054 at commit 
[`0d8cb46`](https://github.com/apache/spark/commit/0d8cb46ccf8cee7ba9d5c55d4cfef8f3011ece2c).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread mgaido91
Github user mgaido91 commented on the issue:

https://github.com/apache/spark/pull/21054
  
@ueshin I found that `corr` and `covar_samp` return `NULL` instead of `NaN` 
or `NaN` instead of `NULL`. So probably the way this cases are handled is 
different in Hive and Spark.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread ueshin
Github user ueshin commented on the issue:

https://github.com/apache/spark/pull/21054
  
@mgaido91 I agree that the fix should be done in the separate PRs after the 
discussion.
Could you list the differences you found for the future discussion? Thanks!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2805/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread mgaido91
Github user mgaido91 commented on the issue:

https://github.com/apache/spark/pull/21054
  
I added the sql tests as you suggested @maropu. Doing this, I found that we 
have some difference in the way we return `NaN` and `null` wrt Hive. I haven't 
changed our behavior though, since this would introduce a behavior change for 
methods which already exist (corr).

I think we have to discuss this and eventually fix in a separate PR if you 
agree, since this is not really related to the introduction of the new 
functions.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #90045 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90045/testReport)**
 for PR 21054 at commit 
[`89295e6`](https://github.com/apache/spark/commit/89295e645e9aeea6ef7d47f35930215953a749d4).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-04-25 Thread mgaido91
Github user mgaido91 commented on the issue:

https://github.com/apache/spark/pull/21054
  
kindly ping @ueshin 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-04-12 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/21054
  
cc @ueshin 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89278/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-04-12 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #89278 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89278/testReport)**
 for PR 21054 at commit 
[`90c266e`](https://github.com/apache/spark/commit/90c266e09e276c37126d8428a4d00f4986d240e5).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `abstract class AverageAggregate extends DeclarativeAggregate `
  * `case class Average(child: Expression) extends AverageAggregate with 
ImplicitCastInputTypes `
  * `abstract class PearsonCorrelation(x: Expression, y: Expression)`
  * `case class Corr(x: Expression, y: Expression)`
  * `abstract class CountAggregate extends DeclarativeAggregate `
  * `case class Count(children: Seq[Expression]) extends CountAggregate `
  * `trait RegrBase extends AggregateFunction with ImplicitCastInputTypes `
  * `case class RegrCount(y: Expression, x: Expression) extends 
CountAggregate`
  * `case class RegrSXX(y: Expression, x: Expression) extends 
CentralMomentAgg(x)`
  * `case class RegrSYY(y: Expression, x: Expression) extends 
CentralMomentAgg(y)`
  * `case class RegrAvgX(y: Expression, x: Expression) extends 
AverageAggregate`
  * `case class RegrAvgY(y: Expression, x: Expression) extends 
AverageAggregate`
  * `case class RegrSXY(y: Expression, x: Expression) extends Covariance(y, 
x)`
  * `case class RegrSlope(y: Expression, x: Expression) extends 
PearsonCorrelation(y, x)`
  * `case class RegrR2(y: Expression, x: Expression) extends 
PearsonCorrelation(y, x)`
  * `case class RegrIntercept(y: Expression, x: Expression) extends 
PearsonCorrelation(y, x)`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2274/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21054
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-04-12 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21054
  
**[Test build #89278 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89278/testReport)**
 for PR 21054 at commit 
[`90c266e`](https://github.com/apache/spark/commit/90c266e09e276c37126d8428a4d00f4986d240e5).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org