Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
Thanks! I'd use this one. merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22131
I preferred the previous one (but yes, definitely good to add the check
about the args size), but I am fine with this one too. Thanks @ueshin
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94919/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94919 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94919/testReport)**
for PR 22131 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94919 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94919/testReport)**
for PR 22131 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
@mgaido91 @mn-mikke On second thought, how about this?
If you don't like it, I'll revert it soon.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94891/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94891 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94891/testReport)**
for PR 22131 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94888/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94888 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94888/testReport)**
for PR 22131 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94887/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94887 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94887/testReport)**
for PR 22131 at commit
Github user mn-mikke commented on the issue:
https://github.com/apache/spark/pull/22131
LGTM too
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22131
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22131
yes, this is my worry too... But I don't have any suggestion for that
If you have anyone, that's great :)
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94891 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94891/testReport)**
for PR 22131 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
Sounds good. I just hope we will never miss to wrap new functions with it.
Thanks!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94883/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94883 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94883/testReport)**
for PR 22131 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22131
sorry, I wasn't very specific in my previous comment. I meant adding a
method like:
```
def validateBinding(e: HigherOrderFunction): Expression = {
e.bind { case (f:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94888 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94888/testReport)**
for PR 22131 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94887 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94887/testReport)**
for PR 22131 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22131
I see now, thanks. The only thing which I am a bit concerned about is the
complexity introduced by this change, in the sense that it is relying very much
on the `bind` implementation of each
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
Actually one of my motivations is to prevent a mistake like #22126. To
create a test, we needed to do the same thing in `bind`. The other is I wanted
to check the exact values each function passes
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22131
I am not sure about this. I think that the `bind` method itself is tested
with the end-to-end tests which have been added. This complicates quite this
part which is meant only to test the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94883/testReport)**
for PR 22131 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
cc @mn-mikke @mgaido91
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
42 matches
Mail list logo
