Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
I am merging this in - maybe I am rushing it but please allow me to go
ahead since it's going to block other PySpark PRs.
At worst case, I am willing to revert and propose this again if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98808/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98808 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98808/testReport)**
for PR 23021 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
adding @holdenk, @ueshin and @icexelloss as well.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
adding @icexelloss as well.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
> Did you test on python3 as well?
Of course!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98808 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98808/testReport)**
for PR 23021 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
> Could you add some descriptions to run a single test file or a single
test case if exists?
Done!
---
-
To
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
Yup!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/23021
One thing - I would put âpandasâ right after test_ so you get the
natural
logical grouping with sorting by file name.
On Tue, Nov 13, 2018 at 4:58 PM Hyukjin Kwon
wrote:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
I am going to push after testing and double checking. The line counts would
look like this
```
54 ./test_utils.py
199 ./test_catalog.py
503
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
> I'd break the pandas udf one into smaller pieces too, as you suggested.
We should also investigate why the runtime didn't improve ...
One suspection from my investigation is, it
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
Yup, will break pandas one into smaller ones as well.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98783/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98783 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98783/testReport)**
for PR 23021 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98782 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98782/testReport)**
for PR 23021 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/23021
Great initiative!
I'd break the pandas udf one into smaller pieces too, as you suggested. We
should also investigate why the runtime didn't improve ...
---
Github user squito commented on the issue:
https://github.com/apache/spark/pull/23021
thanks for working on this @HyukjinKwon . Did you test on python3 as well?
I'm surprised elapsed time is the same -- I would have expected it to be
faster as the tests could run in
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98783 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98783/testReport)**
for PR 23021 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
Elapsed time looks virtually same. All tests looks running fine. The last
commit should show skipped tests fine as well. Should be ready for a look.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98782 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98782/testReport)**
for PR 23021 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98769 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98769/testReport)**
for PR 23021 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98767/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98767 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98767/testReport)**
for PR 23021 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
For your information, here's the line counts for each file:
```
52 ./test_utils.py
197 ./test_catalog.py
43 ./test_group.py
318 ./test_session.py
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98769 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98769/testReport)**
for PR 23021 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
FWIW, I at least double checked if they are any tests missing, and if they
are actually being ran (via coverage).
---
-
To
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
adding @rxin (derived from mailing list)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23021
@BryanCutler and @squito, Here is the official first attempt to break
`pyspark/sql/tests.py` into multiple small files.
If there are no outstanding issues (for instance, if we are
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98767 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98767/testReport)**
for PR 23021 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98765 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98765/testReport)**
for PR 23021 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23021
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98765/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23021
**[Test build #98765 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98765/testReport)**
for PR 23021 at commit
54 matches
Mail list logo
