Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/23148
Cool, opened with what I have so far, will keep an eye out for others for a
while.
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23148
Yeah we'd need a new PR. If you collect a few good improvements just open a
follow up. I was testing by just making a dummy change in a few files and
seeing what it did. It's OK as-is, even.
---
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/23148
> This is already useful in that we can just ask people to run dev/scalafmt
(I'll update developer guids) as the output style looks _also_ just fine. I
won't try to have this automatically add
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/23148
Just pushed a tweak to allow closing parens on same line. New pr for that,
or do we want to keep identifying other tweaks first?
I think the args on their own line is triggered once the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23148
I played with this a little locally, and yeah it does reformat entire files
that are in the diff, and most of what it does is fixing stuff we probably
wouldn't ask for in a PR review. For example is
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/23148
sgtm, i'll be more than happy to review once i get in to the office. :)
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23148
Ah I see. I can add that call in a follow-up to enable it and see how we
like it.
---
-
To unsubscribe, e-mail:
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/23148
i think the best place for this, imo, is in dev/run-tests.py (and called
via run-test-jenkins.py).
On Thu, Nov 29, 2018 at 6:56 AM Sean Owen wrote:
> Merged to master.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23148
Merged to master. @shaneknapp I think you can update the PR builder to call
this now, if we're ready to give it a spin.
---
-
To
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/23148
Thanks for testing it out. I personally like auto-formatting as my company
projects are using scalafmt and we find it's very useful to keep consistent
coding style.
---
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/23148
I tested that example, it will reformat to
```
checkScan(
query,
"struct,address:string,pets:int,"
+
"friends:array>," +
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/23148
My concern is that let's say we have a code like the following which I
copied from `ParquetSchemaPruningSuite.scala`; the scalafmt will complaint the
second line is longer than 98 and reformat it.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99299/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23148
**[Test build #99299 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99299/testReport)**
for PR 23148 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23148
**[Test build #99299 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99299/testReport)**
for PR 23148 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99290/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23148
**[Test build #99290 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99290/testReport)**
for PR 23148 at commit
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/23148
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99291/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23148
**[Test build #99291 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99291/testReport)**
for PR 23148 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23148
**[Test build #99291 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99291/testReport)**
for PR 23148 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23148
**[Test build #99290 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99290/testReport)**
for PR 23148 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99288/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23148
**[Test build #99288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99288/testReport)**
for PR 23148 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23148
**[Test build #99288 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99288/testReport)**
for PR 23148 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
37 matches
Mail list logo
