Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165925913
Note: I'm reverting this patch in *master only* since #10329, the better
alternative, is merged there.
This patch continues to exist in branch-1.6.
---
If your
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/10332#discussion_r47902198
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala ---
@@ -94,7 +94,12 @@ private[mesos] class MesosSubmitRequestServlet(
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10332#discussion_r47909261
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala ---
@@ -94,7 +94,12 @@ private[mesos] class
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165546077
Yeah, just about to comment on that @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10332#discussion_r47939790
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala ---
@@ -94,7 +94,12 @@ private[mesos] class
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/10332#discussion_r47944423
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala ---
@@ -94,7 +94,12 @@ private[mesos] class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165545844
Oh wait, looks like #10359 which fixes this is already merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165545519
OK I'm going to go ahead and revert this patch since it doesn't work...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165227460
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165227299
**[Test build #47830 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47830/consoleFull)**
for PR 10332 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165194859
**[Test build #47830 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47830/consoleFull)**
for PR 10332 at commit
Github user skyluc commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165204770
Code LGTM. Unfortunately, I cannot try it before a couple of hours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165210134
LGTM merging into master and 1.6. Just FYI I might revert this patch in
master because I believe #10329 is a better fix in the long run, but for now
let's just
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10332#discussion_r47816823
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala ---
@@ -94,7 +94,12 @@ private[mesos] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165227464
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165204489
Agreed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165204282
I would lean towards this patch since it only affects mesos and not
standalone mode.
---
If your project is set up for it, you can reply to this email and have your
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165190411
@dragos PTAL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user tnachen opened a pull request:
https://github.com/apache/spark/pull/10332
[SPARK-12345][MESOS] Filter SPARK_HOME when submitting Spark jobs with
Mesos cluster mode.
SPARK_HOME is now causing problem with Mesos cluster mode since
spark-submit script has been changed
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165201670
There seems to be a race condition :) @skyluc opened #10329, but the change
is in `SparkSubmit`. I wonder which one we should take. We tested #10329
locally and it
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10332#issuecomment-165206313
Yes I would also want to just make changes on the Mesos side and not cause
any possible regression on standalone.
---
If your project is set up for it, you can reply
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10332
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
22 matches
Mail list logo
