[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10353#issuecomment-165380331 cc @rxin @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/10353 [SPARK-12395] [SQL] fix resulting columns of outer join For API DataFrame.join(right, usingColumns, joinType), if the joinType is right_outer or full_outer, the resulting join columns could be

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10353#issuecomment-165381524 **[Test build #47914 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47914/consoleFull)** for PR 10353 at commit

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10353#issuecomment-165481397 Does 1.5 have this problem? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10353#discussion_r47922266 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -511,9 +509,26 @@ class DataFrame private[sql](

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10353#issuecomment-165493033 @yhuai No, this is a new feature in 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10353#discussion_r47945571 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -511,9 +509,26 @@ class DataFrame private[sql](

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/10353#discussion_r47893041 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -511,9 +509,26 @@ class DataFrame private[sql](

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10353#issuecomment-165422263 LGTM except for one minor issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10353#issuecomment-165423064 **[Test build #47914 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47914/consoleFull)** for PR 10353 at commit

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10353#issuecomment-165423284 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10353#issuecomment-165423282 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12395] [SQL] fix resulting columns of o...

2015-12-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10353#discussion_r47995473 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -511,9 +509,26 @@ class DataFrame private[sql](