Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55304894
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/69/consoleFull)
for PR 2338 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55333047
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2338#discussion_r17451124
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -360,7 +360,13 @@ private[spark] class Executor(
if
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55334340
I don't have any great ideas for how to write a test for it, but this looks
good to me as well.
---
If your project is set up for it, you can reply to this email and have
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55345239
@andrewor14 @sryza done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55345563
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20182/consoleFull)
for PR 2338 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55349817
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20182/consoleFull)
for PR 2338 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2338#discussion_r17460026
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -360,7 +360,16 @@ private[spark] class Executor(
if
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2338#discussion_r17460029
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -360,7 +360,16 @@ private[spark] class Executor(
if
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55352765
Actually I'll just merge them myself. Thanks @davies. This is going into
master and 1.1.
---
If your project is set up for it, you can reply to this email and have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55352717
LGTM pending very minor wording suggestions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55296407
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/69/consoleFull)
for PR 2338 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55082144
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20081/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55185697
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/29/consoleFull)
for PR 2338 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55198726
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/29/consoleFull)
for PR 2338 at commit
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/2338
[SPARK-3465] fix task metrics aggregation in local mode
Before overwrite t.taskMetrics, take a deepcopy of it.
You can merge this pull request into a Git repository by running:
$ git pull
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55047574
cc @sryza, is there a better way to fix it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55066419
Hi @davies , sorry for causing this bug and thanks for picking it up. To
avoid making the deep copy unnecessarily when running in non-local mode, we
could instead make it
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55070918
@sryza I had changed it to do the copy in Executor, then it's hard to write
a test now. Any idea?
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2338#issuecomment-55073847
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20081/consoleFull)
for PR 2338 at commit
21 matches
Mail list logo
