[GitHub] spark pull request: [SPARK-4096][YARN]let ApplicationMaster accept...

2014-10-28 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/2955#issuecomment-60751424 Yeah like owen said, this commit makes the config item more general. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-4096][YARN]let ApplicationMaster accept...

2014-10-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2955#issuecomment-60816896 Ok cool, I am merging this thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4096][YARN]let ApplicationMaster accept...

2014-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4096][YARN]let ApplicationMaster accept...

2014-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2955#issuecomment-60600212 [Test build #22298 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22298/consoleFull) for PR 2955 at commit

[GitHub] spark pull request: [SPARK-4096][YARN]let ApplicationMaster accept...

2014-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2955#issuecomment-60600224 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4096][YARN]let ApplicationMaster accept...

2014-10-27 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/2955#issuecomment-60637070 Pardon if I misunderstand what's being done here, but does this actually change anything? It seems all that is changing is the ApplicationMaster command line which is

[GitHub] spark pull request: [SPARK-4096][YARN]let ApplicationMaster accept...

2014-10-27 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2955#issuecomment-60637972 It should not change overall behavior. It at least makes this --executor-memory flag act like all the others, even if it is pretty internal, as the comments suggest it