Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/3246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-73262238
Good for me. Let's close this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-73252849
Since the JIRA is a duplicate of 2 others, can I suggest we close this and
try to converge on SPARK-2788? not suggesting its PR is the one to merge, but
at least we can
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-73161950
@tdas Ah, that's great. Thanks for let me know that!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-73101267
Apologies, I have been really backlogged with review because of the
upcoming Spark 1.3 release. The feature merge window for that has closed,
so we can consider this
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-73000140
@tdas Can you have a quick look of this pr? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-72351744
@srowen Does @tdas have time to look at this? If no, maybe others can?
---
If your project is set up for it, you can reply to this email and have your
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-71946175
@tdas Do you have time to look at this to see if it is ready to merge?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-71433530
@viirya OK by me but @tdas will need to weigh in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-71419585
@srowen Is it ok going to merge this feature?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3246#discussion_r23388400
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterInputDStream.scala
---
@@ -85,9 +93,14 @@ class TwitterReceiver(
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-71042483
Hi @srowen, I refactor the codes for the comments. If you have time to
review it, that would be great. Thanks.
---
If your project is set up for it, you can reply to
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-71052031
Fixed in new commit. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-71050223
I think this is a lot better without all the overloads, yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3246#discussion_r23388449
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterUtils.scala
---
@@ -53,7 +67,7 @@ object TwitterUtils {
* @param
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-68342204
Anyone would like to review this pr?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3246#discussion_r22343345
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterUtils.scala
---
@@ -25,6 +25,91 @@ import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3246#discussion_r22343369
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterInputDStream.scala
---
@@ -60,6 +61,7 @@ private[streaming]
class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3246#discussion_r22343378
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterInputDStream.scala
---
@@ -88,6 +90,11 @@ class TwitterReceiver(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3246#discussion_r22343430
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterUtils.scala
---
@@ -112,20 +269,91 @@ object TwitterUtils {
):
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/3246#discussion_r22343534
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterInputDStream.scala
---
@@ -60,6 +61,7 @@ private[streaming]
class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3246#discussion_r22344218
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterInputDStream.scala
---
@@ -60,6 +61,7 @@ private[streaming]
class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/3246#discussion_r22344303
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterInputDStream.scala
---
@@ -60,6 +61,7 @@ private[streaming]
class
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3246#issuecomment-64071312
Any idea about this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
24 matches
Mail list logo
