Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157414057
@nongli I saw you have a related discussion with @chenghao-intel . The
failed test case was introduced in your PR
https://github.com/apache/spark/pull/9480. I am not
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157421827
This change looks good to me. The failing test is not valid anymore and
should be changed to verify that the hash codes are not equal.
---
If your project is set up for
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157434770
Ok. I will also add three more lines for covering the new `hashCode` and
`equals` functions.
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157440630
**[Test build #46095 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46095/consoleFull)**
for PR 9761 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157476581
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157476583
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9761
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157326743
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157304869
**[Test build #46069 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46069/consoleFull)**
for PR 9761 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157326678
**[Test build #46069 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46069/consoleFull)**
for PR 9761 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157326740
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157477293
Thanks! Merging to master and 1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157476327
**[Test build #46095 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46095/consoleFull)**
for PR 9761 at commit
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/9761
[SPARK-8658] [SQL] [FOLLOW-UP] AttributeReference's equals method compares
all the members
Based on the comment of @cloud-fan , update the AttributeReference's
hashCode function by including
14 matches
Mail list logo
