Github user koeninger commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55336261
@marbrus I see what you mean. Updated to basically what you suggested,
aside from building the map once. Let me know, once it's finalized I can try
to test one more
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2345#discussion_r17452614
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -47,6 +48,53 @@ object Optimizer extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55336425
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20170/consoleFull)
for PR 2345 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55336546
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/73/consoleFull)
for PR 2345 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55336553
LGTM to me once the tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55342753
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20176/consoleFull)
for PR 2345 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55345242
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/73/consoleFull)
for PR 2345 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55345198
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20170/consoleFull)
for PR 2345 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55348969
Thanks! I've merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55350225
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20176/consoleFull)
for PR 2345 at commit
GitHub user koeninger opened a pull request:
https://github.com/apache/spark/pull/2345
SPARK-3462 push down filters and projections into Unions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mediacrossinginc/spark SPARK-3462
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55117296
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55172311
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55172771
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20111/consoleFull)
for PR 2345 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55178764
Hey @koeninger, thanks for implementing this optimization!
Overall this looks pretty good. A few minor suggestions:
- I'm not sure that we want to check
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2345#issuecomment-55185718
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20111/consoleFull)
for PR 2345 at commit
17 matches
Mail list logo
