[GitHub] spark pull request #14897: [SPARK-17338][SQL][WIP] add global temp view
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r79752499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -36,6 +36,7 @@ import org.apache.spark.sql.catalyst.util.StringUtils
object SessionCatalog {
val DEFAULT_DATABASE = "default"
+ val GLOBAL_TEMP_VIEW_DATABASE = "_global_temp"
--- End diff --
Maybe change the name to "_global_temporary_views"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14897: [SPARK-17338][SQL][WIP] add global temp view
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r79752478
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -142,8 +145,12 @@ class SessionCatalog(
//
def createDatabase(dbDefinition: CatalogDatabase, ignoreIfExists:
Boolean): Unit = {
-val qualifiedPath =
makeQualifiedPath(dbDefinition.locationUri).toString
val dbName = formatDatabaseName(dbDefinition.name)
+if (dbName == GLOBAL_TEMP_VIEW_DATABASE) {
--- End diff --
Since the name is very specific "_global_temp", it is unlikly that it may
conflict with user table's name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14897: [SPARK-17338][SQL][WIP] add global temp view
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r79752423
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -142,8 +145,12 @@ class SessionCatalog(
//
def createDatabase(dbDefinition: CatalogDatabase, ignoreIfExists:
Boolean): Unit = {
-val qualifiedPath =
makeQualifiedPath(dbDefinition.locationUri).toString
val dbName = formatDatabaseName(dbDefinition.name)
+if (dbName == GLOBAL_TEMP_VIEW_DATABASE) {
--- End diff --
Is this too restrictive? If the user ask directly for
`GLOBAL_TEMP_VIEW_DATABASE `, may be we should allow it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14897: [SPARK-17338][SQL][WIP] add global temp view
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r79744373 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -111,7 +111,8 @@ statement | ALTER TABLE tableIdentifier RECOVER PARTITIONS #recoverPartitions | DROP TABLE (IF EXISTS)? tableIdentifier PURGE? #dropTable | DROP VIEW (IF EXISTS)? tableIdentifier #dropTable -| CREATE (OR REPLACE)? TEMPORARY? VIEW (IF NOT EXISTS)? tableIdentifier +| CREATE (OR REPLACE)? ((LOCAL | GLOBAL)? TEMPORARY)? --- End diff -- Maybe not needing `LOCAL` key word? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14897: [SPARK-17338][SQL][WIP] add global temp view
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r79744336
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ListTablesSuite.scala ---
@@ -33,7 +33,7 @@ class ListTablesSuite extends QueryTest with
TestHiveSingleton with BeforeAndAft
override def beforeAll(): Unit = {
super.beforeAll()
// The catalog in HiveContext is a case insensitive one.
-sessionState.catalog.createTempView(
+sessionState.catalog.createLocalTempView(
--- End diff --
Can we avoid renaming createLocalTempView?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
