[GitHub] spark pull request #14899: [SPARK-17337][SQL] Incomplete algorithm for name ...

[nsyca]

Github user nsyca closed the pull request at:

https://github.com/apache/spark/pull/14899


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #14899: [SPARK-17337][SQL] Incomplete algorithm for name ...

[nsyca]

GitHub user nsyca opened a pull request:

https://github.com/apache/spark/pull/14899

[SPARK-17337][SQL] Incomplete algorithm for name resolution in Catalyst 
paser may lead to incorrect result

## What changes were proposed in this pull request?

Create a new alias for each Project operator under a SubqueryAlias 
operator. This is to resolve the collision of the column/expression of the same 
name referenced in different context of the same
SQL statement. This change aims to resolve an incorrect results problem.


## How was this patch tested?

build/sbt -Phive hive/test
build/sbt sql/test
build/sbt catalyst/test
dev/lint-scala

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsyca/spark nullAware

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/14899.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14899


commit b98865127a39bde885f9b1680cfe608629d59d51
Author: Nattavut Sutyanyong 
Date:   2016-07-29T21:43:56Z

[SPARK-16804][SQL] Correlated subqueries containing LIMIT return incorrect 
results

## What changes were proposed in this pull request?

This patch fixes the incorrect results in the rule ResolveSubquery in 
Catalyst's Analysis phase.

## How was this patch tested?
./dev/run-tests
a new unit test on the problematic pattern.

commit 069ed8f8e5f14dca7a15701945d42fc27fe82f3c
Author: Nattavut Sutyanyong 
Date:   2016-07-29T21:50:02Z

[SPARK-16804][SQL] Correlated subqueries containing LIMIT return incorrect 
results

## What changes were proposed in this pull request?

This patch fixes the incorrect results in the rule ResolveSubquery in 
Catalyst's Analysis phase.

## How was this patch tested?
./dev/run-tests
a new unit test on the problematic pattern.

commit edca333c081e6d4e53a91b496fba4a3ef4ee89ac
Author: Nattavut Sutyanyong 
Date:   2016-07-30T00:28:15Z

New positive test cases

commit 64184fdb77c1a305bb2932e82582da28bb4c0e53
Author: Nattavut Sutyanyong 
Date:   2016-08-01T13:20:09Z

Fix unit test case failure

commit 29f82b05c9e40e7934397257c674b260a8e8a996
Author: Nattavut Sutyanyong 
Date:   2016-08-05T17:42:01Z

blocking TABLESAMPLE

commit ac43ab47907a1ccd6d22f920415fbb4de93d4720
Author: Nattavut Sutyanyong 
Date:   2016-08-05T21:10:19Z

Fixing code styling

commit 631d396031e8bf627eb1f4872a4d3a17c144536c
Author: Nattavut Sutyanyong 
Date:   2016-08-07T18:39:44Z

Correcting Scala test style

commit 7eb9b2dbba3633a1958e38e0019e3ce816300514
Author: Nattavut Sutyanyong 
Date:   2016-08-08T02:31:09Z

One (last) attempt to correct the Scala style tests

commit 1387cf51541408ac20048064fa5e559836af932c
Author: Nattavut Sutyanyong 
Date:   2016-08-12T20:11:50Z

Merge remote-tracking branch 'upstream/master'

commit e8b8a98797c18d04980df46df5bb50617803d4c3
Author: Nattavut Sutyanyong 
Date:   2016-08-15T20:05:30Z

Merge remote-tracking branch 'upstream/master'

commit d011c2879fa6bdf0d12c306a116f0688fc13e8bc
Author: Nattavut Sutyanyong 
Date:   2016-08-29T16:29:09Z

Merge remote-tracking branch 'upstream/master'

commit d9ba54d67d5778429d62a61470fa88773608
Author: Nattavut Sutyanyong 
Date:   2016-08-31T13:58:36Z

Merge remote-tracking branch 'upstream/master'

commit d414a78bc9489860ff755e0949dfda9f23bd6f6e
Author: Nattavut Sutyanyong 
Date:   2016-08-31T15:24:03Z

Initial batch: code fix and unit test case




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org