[GitHub] spark pull request #15106: [SPARK-16439] [SQL] bring back the separator in S...

2016-09-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/15106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #15106: [SPARK-16439] [SQL] bring back the separator in S...

2016-09-14 Thread davies
GitHub user davies opened a pull request:

https://github.com/apache/spark/pull/15106

[SPARK-16439] [SQL] bring back the separator in SQL UI

## What changes were proposed in this pull request?

Currently, the SQL metrics looks like `number of rows: `, it's 
very hard to read how large the number is. So a separator was added by #12425, 
but removed by #14142, because the separator is weird in some locales (for 
example, pl_PL), this PR will add that back, but always use "," as the 
separator, since the SQL UI are all in English.

## How was this patch tested?

Existing tests.

![metrics](https://cloud.githubusercontent.com/assets/40902/14573908/21ad2f00-030d-11e6-9e2c-c544f30039ea.png)




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davies/spark metric_sep

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15106


commit 11a989eacf26ebf0ae3710fa23ef3a63dc618b51
Author: Davies Liu 
Date:   2016-09-14T23:32:03Z

bring the seperator in SQL UI back




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org