GitHub user petermaxlee opened a pull request:
https://github.com/apache/spark/pull/15127
[SPARK-17571][SQL] AssertOnQuery.condition should always return Boolean
value
## What changes were proposed in this pull request?
AssertOnQuery has two apply constructor: one that accepts a closure that
returns boolean, and another that accepts a closure that returns Unit. This is
actually very confusing because developers could mistakenly think that
AssertOnQuery always require a boolean return type and verifies the return
result, when indeed the value of the last statement is ignored in one of the
constructors.
This pull request makes the two constructor consistent and always require
boolean value. It will overall make the test suites more robust against
developer errors.
## How was this patch tested?
This is a test only change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/petermaxlee/spark SPARK-17571
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15127
commit 008eb07a6e8e7a731c2b12b1d490c04dd1dfe3c0
Author: petermaxlee
Date: 2016-09-17T07:35:46Z
[SPARK-17571][SQL] AssertOnQuery.condition should always return Boolean
value
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
