[GitHub] spark pull request #15141: [SPARK-17586][BUILD] Do not call static member vi...

2016-09-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/15141


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #15141: [SPARK-17586][BUILD] Do not call static member vi...

2016-09-18 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request:

https://github.com/apache/spark/pull/15141

[SPARK-17586][BUILD] Do not call static member via instance reference

## What changes were proposed in this pull request?

This PR fixes a warning message as below:

```
[WARNING] .../UnsafeInMemorySorter.java:284: warning: [static] static 
method should be qualified by type name, TaskMemoryManager, instead of by an 
expression
[WARNING]   currentPageNumber = 
memoryManager.decodePageNumber(recordPointer)
```

by referencing the static member via class not instance reference.

## How was this patch tested?

Existing tests should cover this - Jenkins tests.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HyukjinKwon/spark SPARK-17586

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15141


commit 9ec094f093bda3a30ca760a1dadbc7cafddba721
Author: hyukjinkwon 
Date:   2016-09-18T14:26:40Z

Do not call statis member via instance




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org