[GitHub] spark pull request #15406: [Spark-17745][ml][PySpark] update NB python api -...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/15406


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15406: [Spark-17745][ml][PySpark] update NB python api -...

[WeichenXu123]

Github user WeichenXu123 commented on a diff in the pull request:

https://github.com/apache/spark/pull/15406#discussion_r83033809
  
--- Diff: python/pyspark/ml/classification.py ---
@@ -1032,6 +1032,16 @@ class NaiveBayes(JavaEstimator, HasFeaturesCol, 
HasLabelCol, HasPredictionCol, H
 >>> result = model3.transform(test0).head()
 >>> result.prediction
 0.0
+>>> dfWithWeight = spark.createDataFrame([
--- End diff --

seems reasonable...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15406: [Spark-17745][ml][PySpark] update NB python api -...

[sethah]

Github user sethah commented on a diff in the pull request:

https://github.com/apache/spark/pull/15406#discussion_r83023875
  
--- Diff: python/pyspark/ml/classification.py ---
@@ -1032,6 +1032,16 @@ class NaiveBayes(JavaEstimator, HasFeaturesCol, 
HasLabelCol, HasPredictionCol, H
 >>> result = model3.transform(test0).head()
 >>> result.prediction
 0.0
+>>> dfWithWeight = spark.createDataFrame([
--- End diff --

Sorry for the confusion, I was thinking we could just add weights to the 
existing example. I don't think an entirely separate example is necessary. What 
do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15406: [Spark-17745][ml][PySpark] update NB python api

[WeichenXu123]

GitHub user WeichenXu123 opened a pull request:

https://github.com/apache/spark/pull/15406

[Spark-17745][ml][PySpark] update NB python api

## What changes were proposed in this pull request?

update python api for NaiveBayes.

## How was this patch tested?

Existing tests.




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/WeichenXu123/spark nb_python_update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15406


commit 50e0de7d2b03ad8c0ce3dc39313c92f0a7cd619e
Author: WeichenXu 
Date:   2016-10-09T16:10:54Z

update NB python api




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org